Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2148473002: Update https engagement browsertest to always use HTML resources. (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update https engagement browsertest to always use HTML resources. A few https engagement tests used the test server resource at URL '/'. It turns out that this resource gets served with mime type text/plain, which we're planning to have page load metrics infrastructure ignore in the future. This change switches those tests to use '/simple.html' which is served with mime type text/html. Additionally, this change adds a new test Navigate_Both_NonHtmlMainResource, which we'll use to verify that we do not track non-HTML resources. The test currently asserts that we do track these resources, with a comment explaining that we'll update it to assert they are untracked as part of fixing bug 627536. BUG=627536 Committed: https://crrev.com/9ecb585652429b88c8a802833bfe24c7fef128d8 Cr-Commit-Position: refs/heads/master@{#405226}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
Bryan McQuade
PTAL
4 years, 5 months ago (2016-07-12 19:57:34 UTC) #2
felt
lgtm, thanks bryan
4 years, 5 months ago (2016-07-13 16:53:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148473002/1
4 years, 5 months ago (2016-07-13 18:24:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:40:59 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:41:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:44:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ecb585652429b88c8a802833bfe24c7fef128d8
Cr-Commit-Position: refs/heads/master@{#405226}

Powered by Google App Engine
This is Rietveld 408576698