Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to render the frame (with out-of-process iframes), it makes more sense to have the rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
Committed: https://crrev.com/0140a4528d0ee1a2e02173729bba24e969887310
Cr-Commit-Position: refs/heads/master@{#406336}

[lfg, 2016-07-14 17:20:40]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 17:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:45:08]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-07-14 18:53:26]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-07-14 18:53:26]

PTAL.

[Charlie Reis, 2016-07-14 19:12:19]

(Please CC site-isolation-reviews@ on these CLs, since we're tracking them for
OOPIF work.)  :)

[dcheng, 2016-07-18 05:44:11]

Can you update this CL description about why this one moves to be specific to
WebView?

[lfg, 2016-07-18 15:16:53]

Description was changed from

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to
render the frame (with out-of-process iframes), it makes more sense to have the
rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[lfg, 2016-07-18 15:18:08]

On 2016/07/18 05:44:11, dcheng wrote:
> Can you update this CL description about why this one moves to be specific to
> WebView?

I've updated it. This could've been done either way, but I think it makes more
sense to have it in RenderView over RenderWidget, since there's only a single
window even when there are multiple RenderWidgets rendering the frame.

[dcheng, 2016-07-19 13:48:06]

This changes seems fine, but I'm uncertain of how we're going to make this work
in OOPI: this implies it'll only work on the RenderView with the local main
frame, right?

[lfg, 2016-07-19 13:57:26]

On 2016/07/19 13:48:06, dcheng wrote:
> This changes seems fine, but I'm uncertain of how we're going to make this
work
> in OOPI: this implies it'll only work on the RenderView with the local main
> frame, right?

Right, that is another reason to have it in WebViewClient: We have
PageMsg_UpdateWindowScreenRect which is sent from the WebContents, and
received by the swapped-out RenderView (though it's currently handled by the
RenderWidget). We'll still need to move some code between RenderViewImpl and
RenderWidget, but it should not be too hard to do it.

[dcheng, 2016-07-19 14:47:48]

lgtm

[lfg, 2016-07-19 15:10:48]

lfg@chromium.org changed reviewers:
+ avi@chromium.org

[lfg, 2016-07-19 15:10:48]

+avi, please take a look.

[Avi (use Gerrit), 2016-07-19 15:13:53]

lgtm

[lfg, 2016-07-19 15:30:36]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-19 15:30:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:36:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lfg, 2016-07-19 18:02:04]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:02:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:15:21]

Description was changed from

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to
render the frame (with out-of-process iframes), it makes more sense to have the
rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to
render the frame (with out-of-process iframes), it makes more sense to have the
rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[commit-bot: I haz the power, 2016-07-19 19:15:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 19:15:46]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 19:17:49]

Description was changed from

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to
render the frame (with out-of-process iframes), it makes more sense to have the
rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Remove rootWindowRect from WebWidgetClient and move it to WebViewClient.

Since there's a single root window, even when multiple RenderWidgets are used to
render the frame (with out-of-process iframes), it makes more sense to have the
rootWindowRect implementation in the WebViewClient.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Committed: https://crrev.com/0140a4528d0ee1a2e02173729bba24e969887310
Cr-Commit-Position: refs/heads/master@{#406336}
==========

[commit-bot: I haz the power, 2016-07-19 19:17:50]

Patchset 2 (id:??) landed as
https://crrev.com/0140a4528d0ee1a2e02173729bba24e969887310
Cr-Commit-Position: refs/heads/master@{#406336}