Issue 214843006: Docserver: Support //apps APIs.

Issue 214843006: Docserver: Support //apps APIs. (Closed)

Created:
6 years, 9 months ago by Ken Rockot(use gerrit already)

Modified:
6 years, 9 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Docserver: Support //apps APIs. This adds docserver support for interface definitions living in //apps. A placeholder definition exists to prevent the docserver from choking on an empty API path. BUG=357284 NOTRY=true R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260053

Patch Set 1 #

Patch Set 2 : version bump and trailing newlines? #

Total comments: 4

Patch Set 3 : no copy, API->EXTENSIONS_API #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -13 lines)			Patch
A	apps/common/api/dummy.idl	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/api_models.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/api_models_test.py	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/app.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/availability_finder.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/extensions_paths.py	View	1 2	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/214843006/diff/20001/apps/common/api/dummy.idl File apps/common/api/dummy.idl (right): https://codereview.chromium.org/214843006/diff/20001/apps/common/api/dummy.idl#newcode5 apps/common/api/dummy.idl:5: // TODO(jamescook): Remove this once actual APIs live ...

6 years, 9 months ago (2014-03-27 23:49:40 UTC) #2

Ken Rockot(use gerrit already)

https://codereview.chromium.org/214843006/diff/20001/apps/common/api/dummy.idl File apps/common/api/dummy.idl (right): https://codereview.chromium.org/214843006/diff/20001/apps/common/api/dummy.idl#newcode5 apps/common/api/dummy.idl:5: // TODO(jamescook): Remove this once actual APIs live here. ...

6 years, 9 months ago (2014-03-28 01:05:56 UTC) #3

Ken Rockot(use gerrit already)

The CQ bit was checked by rockot@chromium.org

6 years, 9 months ago (2014-03-28 01:06:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/214843006/40001

6 years, 9 months ago (2014-03-28 01:07:18 UTC) #5

Message was sent while issue was closed.

Change committed as 260053

Expand Messages | Collapse Messages