Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 214843003: Log call arguments when extensions call the Chrome preferences API (Closed)

Created:
6 years, 9 months ago by mvrable
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Visibility:
Public.

Description

Log call arguments when extensions call the Chrome preferences API. Without this change, all calls to get or set preferences simply show up as "types.ChromeSetting.get" or "types.ChromeSetting.set" in the extension activity log. With this change, the argument list will include the name of the preference being changed and (when the preference is changed) the new value. BUG=356314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/extensions/activity_log/counting_policy.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mvrable
Here is a patch for bug #356314, which simply adds the affected calls to the ...
6 years, 9 months ago (2014-03-27 18:35:14 UTC) #1
not at google - send to devlin
lgtm for me but you might want to get activity log owner like felt@
6 years, 9 months ago (2014-03-27 18:36:53 UTC) #2
mvrable
I'm one of the co-owners of the activity log now so I don't think her ...
6 years, 9 months ago (2014-03-27 18:45:45 UTC) #3
felt
lgtm, but as mvrable said, he's an OWNER now so my ack isn't really needed ...
6 years, 9 months ago (2014-03-28 02:00:12 UTC) #4
mvrable
The CQ bit was checked by mvrable@chromium.org
6 years, 9 months ago (2014-03-28 03:58:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvrable@chromium.org/214843003/1
6 years, 9 months ago (2014-03-28 03:58:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 07:30:23 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136870
6 years, 9 months ago (2014-03-28 07:30:23 UTC) #8
not at google - send to devlin
I wasn't insinuating that you weren't an owner, just that I'm not and I'm missing ...
6 years, 9 months ago (2014-03-28 14:56:19 UTC) #9
mvrable
The CQ bit was checked by mvrable@chromium.org
6 years, 9 months ago (2014-03-28 16:39:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvrable@chromium.org/214843003/1
6 years, 9 months ago (2014-03-28 16:39:30 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 19:18:58 UTC) #12
Message was sent while issue was closed.
Change committed as 260231

Powered by Google App Engine
This is Rietveld 408576698