third_party/WebKit/Source/wtf/text/StringHash.h - Issue 2148423003: Use StringView for equalIgnoringCase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringHash.h

Issue 2148423003: Use StringView for equalIgnoringCase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK is silly. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringHash.h

diff --git a/third_party/WebKit/Source/wtf/text/StringHash.h b/third_party/WebKit/Source/wtf/text/StringHash.h

index 025f03c0ed9a727c741d26f8bef73ce74858533b..3469f036bc2ac9e47de87b509cc78e9aca9e9343 100644

--- a/third_party/WebKit/Source/wtf/text/StringHash.h

+++ b/third_party/WebKit/Source/wtf/text/StringHash.h

@@ -98,7 +98,12 @@ public:

static inline bool equal(const StringImpl* a, const StringImpl* b)

{

- return equalIgnoringCaseNonNull(a, b);

+ DCHECK(a);

+ DCHECK(b);

+ // Save one branch inside each StringView by derefing the StringImpl,

+ // and another branch inside the compare function by skipping the null

+ // checks.

+ return equalIgnoringCaseAndNullity(*a, *b);

}

static unsigned hash(const RefPtr<StringImpl>& key)