third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp - Issue 2148423003: Use StringView for equalIgnoringCase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

Issue 2148423003: Use StringView for equalIgnoringCase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK is silly. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp ('k') | third_party/WebKit/Source/platform/weborigin/KURL.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

index 67e9caff836c76efa3d406a4058f54b028526890..9e0703333a4871dcc5cf76c47a9893afc981ef4e 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp

@@ -90,7 +90,7 @@ static bool tokenExitsForeignContent(const CompactHTMLToken& token)

static bool tokenExitsSVG(const CompactHTMLToken& token)

{

// FIXME: It's very fragile that we special case foreignObject here to be case-insensitive.

- return equalIgnoringCaseNonNull(token.data().impl(), SVGNames::foreignObjectTag.localName().impl());

+ return equalIgnoringCase(token.data(), SVGNames::foreignObjectTag.localName());

}

static bool tokenExitsMath(const CompactHTMLToken& token)

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp ('k') | third_party/WebKit/Source/platform/weborigin/KURL.h » ('j') | no next file with comments »