Subzero: Instrumented realloc

Subzero: Instrumented realloc

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1608a913b13efb53d18d772cab7e951fecb1287b

[tlively, 2016-07-15 01:55:45]

tlively@google.com changed reviewers:
+ kschimpf@google.com, mcgrathr@chromium.org, stichnot@chromium.org

[Karl, 2016-07-15 15:49:39]

How about adding a test to show that realloc works. That is, resize an allocated
region to a smaller size, and then show that the redzone moved by addressing a
location that was valid in the original allocation, but isn't once resized.

[Jim Stichnoth, 2016-07-21 01:42:09]

lgtm

https://codereview.chromium.org/2148413003/diff/20001/tests_lit/asan_tests/re...
File tests_lit/asan_tests/realloc_shrink.ll (right):

https://codereview.chromium.org/2148413003/diff/20001/tests_lit/asan_tests/re...
tests_lit/asan_tests/realloc_shrink.ll:6: ; RUN:     --fsanitize-address
--sz="-allow-externally-defined-symbols" \
You don't really need the double-quotes here.

https://codereview.chromium.org/2148413003/diff/20001/tests_lit/asan_tests/re...
tests_lit/asan_tests/realloc_shrink.ll:26: ; CHECK: Illegal access of 1 bytes at
"1 bytes" :)

(never mind...)

[tlively, 2016-07-21 06:30:48]

Description was changed from

==========
Subzero: Instrumented realloc

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
Subzero: Instrumented realloc

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[tlively, 2016-07-21 06:30:50]

Committed patchset #2 (id:20001) manually as
1608a913b13efb53d18d772cab7e951fecb1287b (presubmit successful).