Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2148413003: Subzero: Instrumented realloc (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Instrumented realloc BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1608a913b13efb53d18d772cab7e951fecb1287b

Patch Set 1 #

Patch Set 2 : Added realloc test, fixed realloc redzones #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -8 lines) Patch
M runtime/szrt_asan.c View 1 3 chunks +35 lines, -2 lines 0 comments Download
M src/IceASanInstrumentation.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/asan_tests/instrumentmalloc.ll View 1 chunk +11 lines, -5 lines 0 comments Download
A tests_lit/asan_tests/realloc_shrink.ll View 1 1 chunk +26 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
tlively
4 years, 5 months ago (2016-07-15 01:55:46 UTC) #2
Karl
How about adding a test to show that realloc works. That is, resize an allocated ...
4 years, 5 months ago (2016-07-15 15:49:39 UTC) #3
tlively
4 years, 5 months ago (2016-07-20 18:28:56 UTC) #4
Jim Stichnoth
lgtm https://codereview.chromium.org/2148413003/diff/20001/tests_lit/asan_tests/realloc_shrink.ll File tests_lit/asan_tests/realloc_shrink.ll (right): https://codereview.chromium.org/2148413003/diff/20001/tests_lit/asan_tests/realloc_shrink.ll#newcode6 tests_lit/asan_tests/realloc_shrink.ll:6: ; RUN: --fsanitize-address --sz="-allow-externally-defined-symbols" \ You don't really ...
4 years, 5 months ago (2016-07-21 01:42:09 UTC) #5
tlively
4 years, 5 months ago (2016-07-21 06:30:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1608a913b13efb53d18d772cab7e951fecb1287b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698