Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 21484: Update the table of RAM vs number of renderers... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by cpu
Modified:
5 years, 12 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update the table of RAM vs number of renderers - revised my guesstimate of 25 MB per renderer to 40MB, which I think is more appropiate for long lived tabs, since short lived tabs don't really matter here. - the lower end (< 1GB) has less total renderers - the middle has about the same - the upper end (> 2GB) has more renderers - added test to open 34 tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10024

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M chrome/browser/browser_uitest.cc View 1 2 2 chunks +30 lines, -0 lines 1 comment Download
M chrome/browser/renderer_host/render_process_host.cc View 1 chunk +20 lines, -5 lines 1 comment Download
M chrome/common/chrome_constants.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (0 generated)
cpu
8 years, 3 months ago (2009-02-18 23:43:21 UTC) #1
M-A Ruel
http://codereview.chromium.org/21484/diff/7/10 File chrome/browser/browser_uitest.cc (right): http://codereview.chromium.org/21484/diff/7/10#newcode93 Line 93: if (in_process_renderer()) I think the test should run ...
8 years, 3 months ago (2009-02-19 01:14:54 UTC) #2
cpu
http://codereview.chromium.org/21484/diff/7/10 File chrome/browser/browser_uitest.cc (right): http://codereview.chromium.org/21484/diff/7/10#newcode93 Line 93: if (in_process_renderer()) On 2009/02/19 01:14:55, M-A wrote: > ...
8 years, 3 months ago (2009-02-19 02:43:49 UTC) #3
M-A Ruel
lgtm with an optional nit http://codereview.chromium.org/21484/diff/1007/16 File chrome/browser/browser_uitest.cc (right): http://codereview.chromium.org/21484/diff/1007/16#newcode107 Line 107: return; nit: Why ...
8 years, 3 months ago (2009-02-19 12:33:56 UTC) #4
darin (slow to review)
http://codereview.chromium.org/21484/diff/1007/14 File chrome/browser/renderer_host/render_process_host.cc (right): http://codereview.chromium.org/21484/diff/1007/14#newcode39 Line 39: 40 // 3584MB 40 seems too high to ...
8 years, 3 months ago (2009-02-19 18:40:01 UTC) #5
darin (slow to review)
8 years, 3 months ago (2009-02-19 18:41:20 UTC) #6
i see... 20 x 2 == 40 :)  i meant, increase by 50%, so max of 30 instead of 20
in the high memory case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06