Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148393002: Fix find annotated test bot config problem (Closed)

Created:
4 years, 5 months ago by the real yoland
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix config problem #

Total comments: 1

Patch Set 3 : Change to metabuild config #

Patch Set 4 : Fix find annotated test bot config problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -55 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 3 chunks +23 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Find_Annotated_Test.json View 1 2 4 chunks +23 lines, -50 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
the real yoland
4 years, 5 months ago (2016-07-14 18:45:10 UTC) #2
jbudorick
I think you need to retrain expectations. https://codereview.chromium.org/2148393002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (left): https://codereview.chromium.org/2148393002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#oldcode2013 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2013: 'android_config': 'main_builder_mb', ...
4 years, 5 months ago (2016-07-14 20:12:38 UTC) #3
the real yoland
On 2016/07/14 at 20:12:38, jbudorick wrote: > I think you need to retrain expectations. > ...
4 years, 5 months ago (2016-07-14 20:27:16 UTC) #4
jbudorick
https://codereview.chromium.org/2148393002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/2148393002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode2014 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2014: 'android_config': 'main_builder', I think this can and should be ...
4 years, 5 months ago (2016-07-14 20:31:56 UTC) #5
the real yoland
On 2016/07/14 at 20:31:56, jbudorick wrote: > https://codereview.chromium.org/2148393002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py > File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): > > https://codereview.chromium.org/2148393002/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode2014 ...
4 years, 5 months ago (2016-07-14 20:33:42 UTC) #6
jbudorick
lgtm
4 years, 5 months ago (2016-07-14 20:34:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148393002/40001
4 years, 5 months ago (2016-07-14 20:35:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6155)
4 years, 5 months ago (2016-07-14 20:43:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148393002/60001
4 years, 5 months ago (2016-07-14 20:44:51 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6157)
4 years, 5 months ago (2016-07-14 20:52:41 UTC) #16
the real yoland
+phajdan.jr would you please give an OWNER stamp to fix a mistake for Android Find ...
4 years, 5 months ago (2016-07-14 21:02:03 UTC) #18
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-15 14:56:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148393002/60001
4 years, 5 months ago (2016-07-15 23:58:31 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:02:50 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/4e625d0c2dd02fc3f134...

Powered by Google App Engine
This is Rietveld 408576698