Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2148373003: [Mac] Update the deployment target to 10.9 in all the XIB files. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, jochen+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Update the deployment target to 10.9 in all the XIB files. While Chromium's deployment target is still only set to 10.7 due to various code issues, 10.9 is the true minimum required version. BUG=627721 R=avi@chromium.org Committed: https://crrev.com/e72747d498e627f937335b584c357925d5c074db Cr-Commit-Position: refs/heads/master@{#405755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M chrome/app/nibs/AppMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/AvatarMenuItem.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkBar.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkBarFolderWindow.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/BookmarkNameFolder.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/CollectedCookies.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedCookies.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedDownloads.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedGeolocation.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedMIDISysEx.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedMedia.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedMixedScript.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedPlugins.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedPopups.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentBlockedSimple.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ContentProtocolHandlers.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/CookieDetailsView.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/DevicePermissionsPrompt.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/DownloadItem.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/DownloadShelf.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ExtensionInstallPrompt.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptWebstoreData.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/FindBar.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/FirstRunBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/FirstRunDialog.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/GlobalErrorBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/HttpAuthLoginSheet.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/HungRendererDialog.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/ImportProgressDialog.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/InfoBar.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/OneClickSigninBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/OneClickSigninDialog.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/Panel.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/SaveAccessoryView.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/TaskManager.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/Toolbar.xib View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/English.lproj/HttpAuth.xib View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/English.lproj/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Robert Sesek
4 years, 5 months ago (2016-07-14 21:57:40 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-14 22:52:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148373003/1
4 years, 5 months ago (2016-07-15 14:40:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 14:45:10 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 14:46:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e72747d498e627f937335b584c357925d5c074db
Cr-Commit-Position: refs/heads/master@{#405755}

Powered by Google App Engine
This is Rietveld 408576698