Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2148373002: Use lld by default when targeting win on non-win hosts. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use lld by default when targeting win on non-win hosts. build/config/BUILDCONFIG.gn still asserts that target_os == host_os for Windows build, so this currently can't be toggled without further local changes. No behavior change. BUG=495204 Committed: https://crrev.com/570f33c4455186fa5810bc9ec15d7fb909e15ba3 Cr-Commit-Position: refs/heads/master@{#405564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 5 months ago (2016-07-14 18:30:21 UTC) #3
brettw
lgtm
4 years, 5 months ago (2016-07-14 19:29:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148373002/1
4 years, 5 months ago (2016-07-14 19:30:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 20:54:32 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 20:54:35 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:57:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/570f33c4455186fa5810bc9ec15d7fb909e15ba3
Cr-Commit-Position: refs/heads/master@{#405564}

Powered by Google App Engine
This is Rietveld 408576698