Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2148343002: [Extensions] Rework inline installation observation (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Extensions] Rework inline installation observation Instead of observing through the WebstoreAPI, observe directly in the TabHelper. This is a great deal less code, more direct, and also fixes a lifetime issue with the TabHelper being deleted before the inline installation completes. BUG=613949 Review-Url: https://codereview.chromium.org/2103663002 Cr-Commit-Position: refs/heads/master@{#403188} (cherry picked from commit d30a8bd191f17b61938fc87890bffc80049b0774) Committed: https://chromium.googlesource.com/chromium/src/+/2bde772815413a04017f6610fae1bc986c0767ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -290 lines) Patch
D chrome/browser/extensions/api/webstore/webstore_api.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/extensions/api/webstore/webstore_api.cc View 1 chunk +0 lines, -141 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/tab_helper.h View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 7 chunks +114 lines, -21 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 11 chunks +14 lines, -20 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/webstore_install_result.h View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/common/extensions/webstore_install_result.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_inline_install/double_install.html View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 5 months ago (2016-07-14 18:03:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bde772815413a04017f6610fae1bc986c0767ba (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698