Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: components/autofill/core/browser/form_structure_unittest.cc

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure_unittest.cc
diff --git a/components/autofill/core/browser/form_structure_unittest.cc b/components/autofill/core/browser/form_structure_unittest.cc
index 2ef44f3d23e72f706cb65fd69bcbb5fec7ab149b..0463c678cda68319d6a2a2e4a5d8877505bb7959 100644
--- a/components/autofill/core/browser/form_structure_unittest.cc
+++ b/components/autofill/core/browser/form_structure_unittest.cc
@@ -2217,6 +2217,13 @@ TEST_F(FormStructureTest,
form_structure->field(i)->set_form_classifier_outcome(
AutofillUploadContents::Field::NON_GENERATION_ELEMENT);
}
+ if (form_structure->field(i)->name == ASCIIToUTF16("firstname")) {
+ form_structure->field(i)->properties_mask =
+ FieldPropertiesFlags::HAD_FOCUS;
+ } else {
+ form_structure->field(i)->properties_mask =
+ FieldPropertiesFlags::HAD_FOCUS | FieldPropertiesFlags::USER_TYPED;
+ }
}
ServerFieldTypeSet available_field_types;
@@ -2241,24 +2248,31 @@ TEST_F(FormStructureTest,
"given-name", 3U, nullptr);
upload_firstname_field->set_form_classifier_outcome(
AutofillUploadContents::Field::NON_GENERATION_ELEMENT);
+ upload_firstname_field->set_properties_mask(FieldPropertiesFlags::HAD_FOCUS);
AutofillUploadContents::Field* upload_lastname_field = upload.add_field();
test::FillUploadField(upload_lastname_field, 2786066110U, "lastname", "",
"family-name", 5U, nullptr);
upload_lastname_field->set_form_classifier_outcome(
AutofillUploadContents::Field::NON_GENERATION_ELEMENT);
+ upload_lastname_field->set_properties_mask(FieldPropertiesFlags::HAD_FOCUS |
+ FieldPropertiesFlags::USER_TYPED);
AutofillUploadContents::Field* upload_email_field = upload.add_field();
test::FillUploadField(upload_email_field, 1029417091U, "email", "email",
"email", 9U, nullptr);
upload_email_field->set_form_classifier_outcome(
AutofillUploadContents::Field::NON_GENERATION_ELEMENT);
+ upload_email_field->set_properties_mask(FieldPropertiesFlags::HAD_FOCUS |
+ FieldPropertiesFlags::USER_TYPED);
AutofillUploadContents::Field* upload_username_field = upload.add_field();
test::FillUploadField(upload_username_field, 239111655U, "username", "text",
"email", 86U, nullptr);
upload_username_field->set_form_classifier_outcome(
AutofillUploadContents::Field::NON_GENERATION_ELEMENT);
+ upload_username_field->set_properties_mask(FieldPropertiesFlags::HAD_FOCUS |
+ FieldPropertiesFlags::USER_TYPED);
AutofillUploadContents::Field* upload_password_field = upload.add_field();
test::FillUploadField(upload_password_field, 2051817934U, "password",
@@ -2268,6 +2282,8 @@ TEST_F(FormStructureTest,
upload_password_field->set_generation_type(
AutofillUploadContents::Field::
MANUALLY_TRIGGERED_GENERATION_ON_SIGN_UP_FORM);
+ upload_password_field->set_properties_mask(FieldPropertiesFlags::HAD_FOCUS |
+ FieldPropertiesFlags::USER_TYPED);
std::string expected_upload_string;
ASSERT_TRUE(upload.SerializeToString(&expected_upload_string));

Powered by Google App Engine
This is Rietveld 408576698