Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index 9a28887ee896a86c55eba2a35a60ed7426500c6e..b0da2dedd23a482c3ab393dff449d35447f98467 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -14,6 +14,7 @@
#include "components/autofill/content/renderer/autofill_agent.h"
#include "components/autofill/content/renderer/password_form_conversion_utils.h"
#include "components/autofill/core/common/form_data_predictions.h"
+#include "components/autofill/core/common/password_form.h"
#include "components/autofill/core/common/password_form_field_prediction_map.h"
#include "components/autofill/core/common/password_form_fill_data.h"
#include "content/public/renderer/render_frame_observer.h"
@@ -102,6 +103,9 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
RendererSavePasswordProgressLogger* logger,
std::vector<blink::WebInputElement>* elements);
+ // Called when the focused node has changed.
+ void FocusedNodeHasChanged(const blink::WebNode& node);
+
bool logging_state_active() const { return logging_state_active_; }
protected:
@@ -239,10 +243,13 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
// but the submit may still fail (i.e. doesn't pass JavaScript validation).
std::unique_ptr<PasswordForm> provisionally_saved_form_;
- // Contains the most recent text that user typed or PasswordManager autofilled
- // in input elements. Used for storing username/password before JavaScript
+ // Map WebFormControlElement to the pair of:
+ // 1) The most recent text that user typed or PasswordManager autofilled in
+ // input elements. Used for storing username/password before JavaScript
// changes them.
- ModifiedValues nonscript_modified_values_;
+ // 2) Field properties mask, i.e. whether the field was autofilled, modified
+ // by user, etc. (see FieldPropertiesMask).
+ FieldValueAndPropertiesMaskMap field_value_and_properties_map_;
PasswordValueGatekeeper gatekeeper_;

Powered by Google App Engine
This is Rietveld 408576698