Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index ebcda2a24d468632f700311a65341bd0c00fe6c8..9f32ae842d3f42b64f2b27b2873f6b798c9a2fec 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -290,11 +290,14 @@ void AutofillAgent::FocusChangeComplete() {
WebElement focused_element;
if (!doc.isNull())
focused_element = doc.focusedElement();
-
- if (!focused_element.isNull() && password_generation_agent_ &&
- password_generation_agent_->FocusedNodeHasChanged(focused_element)) {
- is_generation_popup_possibly_visible_ = true;
- is_popup_possibly_visible_ = true;
+ if (!focused_element.isNull()) {
+ if (password_generation_agent_ &&
+ password_generation_agent_->FocusedNodeHasChanged(focused_element)) {
+ is_generation_popup_possibly_visible_ = true;
+ is_popup_possibly_visible_ = true;
+ }
+ if (password_autofill_agent_)
+ password_autofill_agent_->FocusedNodeHasChanged(focused_element);
}
}
@@ -695,7 +698,8 @@ void AutofillAgent::QueryAutofillSuggestions(
&field)) {
// If we didn't find the cached form, at least let autocomplete have a shot
// at providing suggestions.
- WebFormControlElementToFormField(element, form_util::EXTRACT_VALUE, &field);
+ WebFormControlElementToFormField(element, nullptr, form_util::EXTRACT_VALUE,
+ &field);
}
std::vector<base::string16> data_list_values;

Powered by Google App Engine
This is Rietveld 408576698