Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8995)

Unified Diff: chrome/installer/mac/app/NetworkCommunication.h

Issue 2148293005: Migrate mac installer to delegate-driven model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Last patch before CQ Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mac/app/MainDelegate.m ('k') | chrome/installer/mac/app/NetworkCommunication.m » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/app/NetworkCommunication.h
diff --git a/chrome/installer/mac/app/NetworkCommunication.h b/chrome/installer/mac/app/NetworkCommunication.h
index 803c2db25c6ca3fe5e8b34f3bfd41f5e5ace7273..c616a20764b52ef3bb3b175ab0affab38658c3b0 100644
--- a/chrome/installer/mac/app/NetworkCommunication.h
+++ b/chrome/installer/mac/app/NetworkCommunication.h
@@ -7,16 +7,14 @@
#import <Foundation/Foundation.h>
-typedef void (^DataTaskCompletionHandler)(NSData*, NSURLResponse*, NSError*);
-typedef void (^DownloadTaskCompletionHandler)(NSURL*, NSURLResponse*, NSError*);
-
+// TODO: talk to @sdy about this class
@interface NetworkCommunication : NSObject
+typedef void (^DataTaskCompletionHandler)(NSData*, NSURLResponse*, NSError*);
+
@property(nonatomic, copy) NSMutableURLRequest* request;
@property(nonatomic, copy) NSURLSession* session;
@property(nonatomic, copy) DataTaskCompletionHandler dataResponseHandler;
-@property(nonatomic, copy)
- DownloadTaskCompletionHandler downloadResponseHandler;
- (id)init;
- (id)initWithDelegate:(id)delegate;
@@ -26,8 +24,7 @@ typedef void (^DownloadTaskCompletionHandler)(NSURL*, NSURLResponse*, NSError*);
- (NSMutableURLRequest*)createRequestWithUrlAsString:(NSString*)urlString
andXMLBody:(NSXMLDocument*)body;
// Adds a data task to the run loop using the request instance variable.
-- (void)sendDataRequestWithCompletionHandler:
- (DataTaskCompletionHandler)completionHandler;
+- (void)sendDataRequest;
// Adds a download task to the run loop using the request instance variable.
- (void)sendDownloadRequest;
« no previous file with comments | « chrome/installer/mac/app/MainDelegate.m ('k') | chrome/installer/mac/app/NetworkCommunication.m » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698