Migrate mac installer to delegate-driven model

chrome/installer/mac/app/OmahaCommunication.h

Index: chrome/installer/mac/app/OmahaCommunication.h
diff --git a/chrome/installer/mac/app/OmahaCommunication.h b/chrome/installer/mac/app/OmahaCommunication.h
index 54a377f1c8361e71252c7dd8680436e0264ae8ca..a91dc211a14ee6cd9f0674992aeb9826ff54db95 100644
--- a/chrome/installer/mac/app/OmahaCommunication.h
+++ b/chrome/installer/mac/app/OmahaCommunication.h
@@ -7,20 +7,26 @@
 
 #import <Foundation/Foundation.h>
 
-#include "NetworkCommunication.h"
+#import "NetworkCommunication.h"
 
-typedef void (^OmahaRequestCompletionHandler)(NSData*, NSError*);
+@protocol OmahaCommunicationDelegate
+- (void)onOmahaSuccessWithData:(NSData*)data;
+@end
 
-@interface OmahaCommunication : NSObject
+@interface OmahaCommunication : NSObject<NSURLSessionDataDelegate> {
+  NSMutableData* _dataCollected;
+  id<OmahaCommunicationDelegate> _delegate;
+}
 
 @property(nonatomic, copy) NSXMLDocument* requestXMLBody;
 @property(nonatomic, copy) NetworkCommunication* sessionHelper;

[Sidney San Martín, 2016/07/22 02:30:17]

Not part of this CL, so feel free to ignore for now: It doesn't look like these
two properties are used (OmahaCommunication.m just assigns directly to the
instance variables) — and NetworkCommunication isn't copyable, so it would crash
if you tried to assign to this property. Maybe drop them? I'm not 100% sure on
the convention here around classes using ivars directly.

+@property(nonatomic, assign) id<OmahaCommunicationDelegate> delegate;
 
 - (id)init;
 - (id)initWithBody:(NSXMLDocument*)xmlBody;
 
 // Sends the request created using the session helper.
-- (void)sendRequestWithBlock:(OmahaRequestCompletionHandler)block;
+- (void)sendRequest;
 
 @end