Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: chrome/installer/mac/app/main.m

Issue 2148293005: Migrate mac installer to delegate-driven model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the rest of Sidney's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/main.m
diff --git a/chrome/installer/mac/app/main.m b/chrome/installer/mac/app/main.m
index 3f718136da58412eba1d290a526b7b9d7943aa83..89e9273cc975f69135e185d19a28d22bd902d40c 100644
--- a/chrome/installer/mac/app/main.m
+++ b/chrome/installer/mac/app/main.m
@@ -3,32 +3,14 @@
// found in the LICENSE file.
#import <Foundation/Foundation.h>
+#import "MainDelegate.h"
-#import "Downloader.h"
-#import "OmahaCommunication.h"
-#import "OmahaXMLRequest.h"
-#import "SystemInfo.h"
+int main(int argc, const char* argv[]) {
+ MainDelegate* delegate = [[MainDelegate alloc] init];
+ [delegate talkToOmaha];
-// TODO: add a class that takes care of what main is doing now
-void talkToOmahaThenExecuteBlock(OmahaRequestCompletionHandler block) {
- NSXMLDocument* requestBody = [OmahaXMLRequest createXMLRequestBody];
- OmahaCommunication* messenger =
- [[OmahaCommunication alloc] initWithBody:requestBody];
- [messenger sendRequestWithBlock:block];
-}
-
-int main() {
- talkToOmahaThenExecuteBlock(^(NSData* data, NSError* error) {
- if (error) {
- NSLog(@"%@", [error localizedDescription]);
- return;
- }
- Downloader* download = [[Downloader alloc] init];
- [download downloadChromeImageToDownloadsDirectory:data];
- });
-
- // [[NSRunLoop mainRunLoop] run];
- [[NSRunLoop mainRunLoop]
- runUntilDate:[NSDate dateWithTimeIntervalSinceNow:3]];
+ [[NSRunLoop mainRunLoop] run];
+ // [[NSRunLoop mainRunLoop]
+ // runUntilDate:[NSDate dateWithTimeIntervalSinceNow:10]];
return 1;
}

Powered by Google App Engine
This is Rietveld 408576698