Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2702)

Unified Diff: chrome/installer/mac/app/MainDelegate.m

Issue 2148293005: Migrate mac installer to delegate-driven model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the rest of Sidney's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/MainDelegate.m
diff --git a/chrome/installer/mac/app/MainDelegate.m b/chrome/installer/mac/app/MainDelegate.m
new file mode 100644
index 0000000000000000000000000000000000000000..b84fe9915736ce6dbacd1f8b273a27bd1a804ef4
--- /dev/null
+++ b/chrome/installer/mac/app/MainDelegate.m
@@ -0,0 +1,38 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Foundation/Foundation.h>
+#import <Cocoa/Cocoa.h>
Mark Mentovai 2016/07/19 21:07:40 Sort ’em! But if you’re #importing Cocoa, there’s
+
+#import "Downloader.h"
+#import "MainDelegate.h"
+#import "OmahaCommunication.h"
+#import "OmahaXMLRequest.h"
+#import "SystemInfo.h"
+
+@implementation MainDelegate
+
+- (void)talkToOmaha {
+ NSXMLDocument* requestBody = [OmahaXMLRequest createXMLRequestBody];
+
+ OmahaCommunication* messenger =
+ [[OmahaCommunication alloc] initWithBody:requestBody];
+ [messenger setDelegate:self];
Sidney San Martín 2016/07/19 23:19:20 Pretty trivial: you can just say `messenger.delega
+
+ [messenger sendRequest];
+}
+
+- (void)downloadChromeWithData:(NSData*)data {
+ Downloader* download = [[Downloader alloc] init];
+ [download setDelegate:self];
Sidney San Martín 2016/07/19 23:19:20 Ditto, could be `download.delegate = self;`.
+
+ [download downloadChromeImageToDownloadsDirectory:data];
+}
+
+- (void)unpackDMG {
+ // TODO: replace the line of code below with real code someday
+ exit(0);
+}
+
+@end

Powered by Google App Engine
This is Rietveld 408576698