chrome/installer/mac/app/OmahaXMLRequest.m - Issue 2148293005: Migrate mac installer to delegate-driven model

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/OmahaXMLRequest.m

Issue 2148293005: Migrate mac installer to delegate-driven model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments except NetworkCommunication Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Foundation/Foundation.h>	5 #include "OmahaXMLRequest.h"

6	6

7 #include "OmahaXMLRequest.h"

8 #include "SystemInfo.h"	7 #include "SystemInfo.h"

9	8

10 @implementation OmahaXMLRequest : NSObject	9 @implementation OmahaXMLRequest : NSObject

11	10

12 + (NSXMLElement)createElementWithName:(NSString)name {	11 + (NSXMLElement)createElementWithName:(NSString)name {

13 return [[NSXMLElement alloc] initWithName:name];	12 return [[NSXMLElement alloc] initWithName:name];

14 }	13 }

15	14

16 + (void)forElement:(NSXMLElement*)element	15 + (void)forElement:(NSXMLElement*)element

17 AddAttribute:(NSString*)attribute	16 AddAttribute:(NSString*)attribute

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 NSXMLElement* updateChildChild =	64 NSXMLElement* updateChildChild =

66 [OmahaXMLRequest createElementWithName:@"updatecheck"];	65 [OmahaXMLRequest createElementWithName:@"updatecheck"];

67 [appChild addChild:updateChildChild];	66 [appChild addChild:updateChildChild];

68	67

69 NSXMLDocument* requestXMLDocument =	68 NSXMLDocument* requestXMLDocument =

70 [[NSXMLDocument alloc] initWithRootElement:root];	69 [[NSXMLDocument alloc] initWithRootElement:root];

71 return requestXMLDocument;	70 return requestXMLDocument;

72 }	71 }

73	72

74 @end	73 @end

OLD	NEW

« chrome/installer/mac/app/OmahaCommunication.m ('K') | « chrome/installer/mac/app/OmahaCommunication.m ('k') | chrome/installer/mac/app/main.m » ('j') | chrome/installer/mac/app/main.m » ('J')