chrome/installer/mac/app/MainDelegate.h - Issue 2148293005: Migrate mac installer to delegate-driven model

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/MainDelegate.h

Issue 2148293005: Migrate mac installer to delegate-driven model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments except NetworkCommunication Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_MAINDELEGATE_H_

	6 #define CHROME_INSTALLER_MAC_APP_MAINDELEGATE_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 #import "Downloader.h"

	11 #import "OmahaCommunication.h"

	12

	13 // TODO: move this into the unpacking file when created

	14 @protocol UnpackDelegate

	15 - (void)onDownloadSuccess;
	Sidney San Martín 2016/07/22 02:30:17 This method is already in DownloaderDelegate, an U This method is already in DownloaderDelegate, an UnpackDelegate would probably have different methods — maybe drop this protocol for now?
	16 @end

	17

	18 @interface MainDelegate

	19 : NSObject<OmahaCommunicationDelegate, DownloaderDelegate, UnpackDelegate>

	20 - (void)runApplication;

	21 @end

	22

	23 #endif // CHROME_INSTALLER_MAC_APP_MAINDELEGATE_H_

OLD	NEW