Excluded non-chromeos source files in chromeos build

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # There are two sections of sources:
     # * "Platform"-based sources (OS, toolkit, etc.)
     # * Feature/directory-based sources (e.g., history, printing)
 
@@ skipping 3048 matching lines @@
             }],
             ['OS!="mac"', {
               'sources': [ '<@(chrome_browser_ui_views_non_mac_sources)' ],
               'dependencies': [
                 '../ui/gfx/gfx.gyp:gfx_vector_icons',
               ],
               'conditions': [
                 ['enable_extensions==1', {
                   'sources': [ '<@(chrome_browser_ui_views_extensions_non_mac_sources)' ],
                 }],
+                [ 'chromeos == 1', {
+                  'sources!': [
+                    'browser/ui/views/profiles/profile_chooser_view.cc',

[msw, 2016/07/15 15:51:27]

I wonder if we intend to support these in Mac Views, and if they could just move
to chrome_browser_ui_views_non_chromeos_sources; +tapted@ for thoughts.
(profile_chooser_view_browsertest.cc comment: # This should be brought up on OSX
Views but not CrOS.)

[tapted, 2016/07/18 21:20:59]

ooh - yep! chrome_browser_ui_views_non_chromeos_sources is the right place for
these. As it is, I think this will break the `compile` step with
mac_views_browser=1 in GYP_DEFINES

chrome_browser_ui_views_non_chromeos_sources is already guarded by a similar
condition, but with the fix for mac_views_browser=1

            ['chromeos == 0 and (OS!="mac" or mac_views_browser==1)', {
              'sources': [ '<@(chrome_browser_ui_views_non_chromeos_sources)' ],
            }],

[Jane, 2016/07/19 04:33:55]

Done. Moved these classes to chrome_browser_ui_views_non_chromeos_sources. As
for profile_chooser_view_browertest.cc, I added "mac_views_browser==1" as a
condition.

+                    'browser/ui/views/profiles/profile_chooser_view.h',

[msw, 2016/07/15 15:51:27]

You'll need to make includes of this header non-cros-specific.

[Jane, 2016/07/19 04:33:55]

Done. 
I had to do some refactoring in bookmark_bubble_sign_in_delegate_browsertest.cc
though for it to pass; if you think this is not worth it, I can revert back to
including profile_chooser_view.h at all times.

+                    'browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc',
+                    'browser/ui/views/sync/profile_signin_confirmation_dialog_views.h',
+                  ],
+                }],
               ],
             }],
             ['enable_extensions==1', {
               'dependencies': [
                 '<(DEPTH)/extensions/components/extensions_components.gyp:native_app_window',
               ],
             }],
           ],
         }],
         ['use_aura==1 and chromeos==0 and use_ozone==0 and OS=="linux"', {
@@ skipping 289 matching lines @@
           ],
           'sources': [
             '<@(chrome_browser_ui_non_mobile_sources)',
             '<@(chrome_browser_ui_omnibox_non_mobile_sources)',
           ],
         }],
       ],
     },
   ],
 }