build/common.gypi - Issue 2148283002: Reland of Disable "taking address of packed member" clang warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 2148283002: Reland of Disable "taking address of packed member" clang warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 5c1914ce900746f679780caab7a475e867ea3c7d..29f5a46477e1245e93439666cc1529f38ea5eb23 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3036,6 +3036,10 @@

['enable_wexit_time_destructors==1 and OS!="win"', {

# TODO: Enable on Windows too, http://crbug.com/404525

'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},

+ }],

+ ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="270823-1"', {

Nico 2016/07/14 17:04:24 this has to say 274369 now

Reid Kleckner 2016/07/14 17:15:10 Done.

+ # TODO(eugenis): https://crbug.com/619640

+ 'variables': { 'clang_warning_flags': ['-Wno-address-of-packed-member']},

}],

['chromium_code==0', {

'variables': {

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »