Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2148283002: Reland of Disable "taking address of packed member" clang warning. (Closed)

Created:
4 years, 5 months ago by Reid Kleckner
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable "taking address of packed member" clang warning. (patchset #1 id:1 of https://codereview.chromium.org/2066503004/ ) Reason for revert: The warning was relanded upstream this morning. Original issue's description: > Revert of Disable "taking address of packed member" clang warning. (patchset #3 id:40001 of https://codereview.chromium.org/2059143003/ ) > > Reason for revert: > The warning got reverted upstream. > > Original issue's description: > > Disable "taking address of packed member" clang warning. > > > > Pending cleanup. > > > > BUG=619640 > > > > Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e > > Cr-Commit-Position: refs/heads/master@{#399572} > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=619640 > > Committed: https://crrev.com/f999d8350f0fbdefac8875135ca3540c64d2f3f4 > Cr-Commit-Position: refs/heads/master@{#399686} TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619640 Committed: https://crrev.com/805bf6aaa5de841e0cf987e0d7005f5abd7df54c Cr-Commit-Position: refs/heads/master@{#405538}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Reid Kleckner
Created Reland of Disable "taking address of packed member" clang warning.
4 years, 5 months ago (2016-07-14 17:00:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148283002/1
4 years, 5 months ago (2016-07-14 17:00:26 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 17:01:02 UTC) #4
Nico
needs a change: https://codereview.chromium.org/2148283002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2148283002/diff/1/build/common.gypi#newcode3040 build/common.gypi:3040: ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="270823-1"', { this has ...
4 years, 5 months ago (2016-07-14 17:04:24 UTC) #5
Reid Kleckner
fix revision
4 years, 5 months ago (2016-07-14 17:14:51 UTC) #7
Reid Kleckner
https://codereview.chromium.org/2148283002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2148283002/diff/1/build/common.gypi#newcode3040 build/common.gypi:3040: ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="270823-1"', { On 2016/07/14 17:04:24, Nico wrote: ...
4 years, 5 months ago (2016-07-14 17:15:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148283002/60001
4 years, 5 months ago (2016-07-14 17:15:30 UTC) #11
Nico
lgtm
4 years, 5 months ago (2016-07-14 17:15:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-07-14 19:25:55 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/805bf6aaa5de841e0cf987e0d7005f5abd7df54c Cr-Commit-Position: refs/heads/master@{#405538}
4 years, 5 months ago (2016-07-14 19:29:00 UTC) #15
Nico
4 years, 5 months ago (2016-07-14 20:44:17 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2145243003/ by thakis@chromium.org.

The reason for reverting is: Warning was reverted upstream again..

Powered by Google App Engine
This is Rietveld 408576698