Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 2148253003: IndexedDB: Implement explicit queue for IDBOpenDBRequests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use pending member, other review nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index 1ade603165a2c3e7bf1a18411e8e6180b054c0d4..82089c4972fdadf4800aae0250455eec022a567d 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -194,18 +194,30 @@ TEST(IndexedDBDatabaseTest, PendingDelete) {
IndexedDBDatabaseMetadata::DEFAULT_VERSION);
db->OpenConnection(connection);
+ EXPECT_EQ(db->ConnectionCount(), 1UL);
+ EXPECT_EQ(db->ActiveOpenDeleteCount(), 0UL);
+ EXPECT_EQ(db->PendingOpenDeleteCount(), 0UL);
EXPECT_FALSE(backing_store->HasOneRef()); // local and db
scoped_refptr<MockDeleteCallbacks> request2(new MockDeleteCallbacks());
db->DeleteDatabase(request2);
+ EXPECT_EQ(db->ConnectionCount(), 1UL);
+ EXPECT_EQ(db->ActiveOpenDeleteCount(), 1UL);
+ EXPECT_EQ(db->PendingOpenDeleteCount(), 0UL);
EXPECT_FALSE(request2->blocked_called());
db->VersionChangeIgnored();
EXPECT_TRUE(request2->blocked_called());
+ EXPECT_EQ(db->ConnectionCount(), 1UL);
+ EXPECT_EQ(db->ActiveOpenDeleteCount(), 1UL);
+ EXPECT_EQ(db->PendingOpenDeleteCount(), 0UL);
EXPECT_FALSE(backing_store->HasOneRef()); // local and db
db->Close(request1->connection(), true /* forced */);
+ EXPECT_EQ(db->ConnectionCount(), 0UL);
+ EXPECT_EQ(db->ActiveOpenDeleteCount(), 0UL);
+ EXPECT_EQ(db->PendingOpenDeleteCount(), 0UL);
EXPECT_FALSE(db->backing_store());
EXPECT_TRUE(backing_store->HasOneRef()); // local
« no previous file with comments | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/resources/indexed_db/indexeddb_internals.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698