Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2148243003: Move MultiProfileMediaTrayItemTest to //ash/common (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MultiProfileMediaTrayItemTest to //ash/common It has no aura dependencies, and that's where the code under test lives. BUG=none TEST=ash_unittests Committed: https://crrev.com/55fe9c3767cb255fe8ad96bedaf2787e2b4fbcec Cr-Commit-Position: refs/heads/master@{#405526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
M ash/ash.gyp View 2 chunks +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
James Cook
msw, please take a look
4 years, 5 months ago (2016-07-14 16:07:28 UTC) #4
msw
lgtm
4 years, 5 months ago (2016-07-14 17:49:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148243003/1
4 years, 5 months ago (2016-07-14 18:51:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 18:57:15 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 18:57:24 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 18:59:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55fe9c3767cb255fe8ad96bedaf2787e2b4fbcec
Cr-Commit-Position: refs/heads/master@{#405526}

Powered by Google App Engine
This is Rietveld 408576698