Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 214823011: Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: squash a lil' bug Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_cache.cc
diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc
index 431979ebd4c8a6875473e974780ec7bdee3e7ce0..2530bff7b9b7c084f94fe0f341f8e7acbbcff028 100644
--- a/components/autofill/content/renderer/form_cache.cc
+++ b/components/autofill/content/renderer/form_cache.cc
@@ -206,9 +206,7 @@ bool FormCache::ClearFormWithElement(const WebInputElement& element) {
input_element->setSelectionRange(length, length);
}
} else if (IsTextAreaElement(control_element)) {
- WebTextAreaElement text_area = control_element.to<WebTextAreaElement>();
- text_area.setValue(base::string16());
- text_area.dispatchFormControlChangeEvent();
+ control_element.setValue(base::string16(), true);
} else if (IsSelectElement(control_element)) {
WebSelectElement select_element = control_element.to<WebSelectElement>();
@@ -216,8 +214,7 @@ bool FormCache::ClearFormWithElement(const WebInputElement& element) {
initial_value_iter = initial_select_values_.find(select_element);
if (initial_value_iter != initial_select_values_.end() &&
select_element.value() != initial_value_iter->second) {
- select_element.setValue(initial_value_iter->second);
- select_element.dispatchFormControlChangeEvent();
+ select_element.setValue(initial_value_iter->second, true);
}
} else {
WebInputElement input_element = control_element.to<WebInputElement>();

Powered by Google App Engine
This is Rietveld 408576698