components/autofill/content/renderer/form_cache.cc - Issue 214823011: Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 214823011: Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: d'oh Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_cache.cc

diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc

index d9acf3755296bea33d9b8c2b8b90745c0bf3f146..842b1f207354fb8d58c36589d6b8dd2d6037693f 100644

--- a/components/autofill/content/renderer/form_cache.cc

+++ b/components/autofill/content/renderer/form_cache.cc

@@ -206,9 +206,7 @@ bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {

input_element->setSelectionRange(length, length);

}

} else if (IsTextAreaElement(control_element)) {

- WebTextAreaElement text_area = control_element.to<WebTextAreaElement>();

- text_area.setValue(base::string16());

- text_area.dispatchFormControlChangeEvent();

+ control_element.setValue(base::string16(), true);

} else if (IsSelectElement(control_element)) {

WebSelectElement select_element = control_element.to<WebSelectElement>();

@@ -216,8 +214,7 @@ bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {

initial_value_iter = initial_select_values_.find(select_element);

if (initial_value_iter != initial_select_values_.end() &&

select_element.value() != initial_value_iter->second) {

- select_element.setValue(initial_value_iter->second);

- select_element.dispatchFormControlChangeEvent();

+ select_element.setValue(initial_value_iter->second, true);

}

} else {

WebInputElement input_element = control_element.to<WebInputElement>();