Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select>

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 148 matching lines @@
       curr_elements->form_element = fe;
       results->push_back(curr_elements.release());
     }
   }
 }
 
 bool IsElementEditable(const blink::WebInputElement& element) {
   return element.isEnabled() && !element.isReadOnly();
 }
 
-void SetElementAutofilled(blink::WebInputElement* element, bool autofilled) {
-  if (element->isAutofilled() == autofilled)
-    return;
-  element->setAutofilled(autofilled);
-  // Notify any changeEvent listeners.
-  element->dispatchFormControlChangeEvent();
-}

[Ilya Sherman, 2014/03/29 00:07:07]

Why is this function safe to remove?  Does setAutofilled() now always dispatch a
change event?

[Dan Beam, 2014/03/29 00:51:14]

no, passing true to setValue() dispatches a change

-
 bool DoUsernamesMatch(const base::string16& username1,
                       const base::string16& username2,
                       bool exact_match) {
   if (exact_match)
     return username1 == username2;
   return StartsWith(username1, username2, true);
 }
 
 // Returns |true| if the given element is both editable and has permission to be
 // autocompleted. The latter can be either because there is no
@@ skipping 101 matching lines @@
 }
 
 bool PasswordAutofillAgent::TextDidChangeInTextField(
     const blink::WebInputElement& element) {
   LoginToPasswordInfoMap::const_iterator iter =
       login_to_password_info_.find(element);
   if (iter == login_to_password_info_.end())
     return false;
 
   // The input text is being changed, so any autofilled password is now
   // outdated.

[Dan Beam, 2014/03/29 00:51:14]

^ there should already be a change dispatched in this case

   blink::WebInputElement username = element;  // We need a non-const.
+  username.setAutofilled(false);
+
   blink::WebInputElement password = iter->second.password_field;
-  SetElementAutofilled(&username, false);
   if (password.isAutofilled()) {
-    password.setValue(base::string16());
-    SetElementAutofilled(&password, false);
+    password.setValue(base::string16(), true);

[Dan Beam, 2014/03/29 00:51:14]

sends change ^ (when appropriate)

+    password.setAutofilled(false);
   }
 
   // If wait_for_username is true we will fill when the username loses focus.
   if (iter->second.fill_data.wait_for_username)
     return false;
 
   if (!element.isText() || !IsElementAutocompletable(element) ||
       !IsElementAutocompletable(password)) {
     return false;
   }
@@ skipping 490 matching lines @@
   // fields.
 
   // Don't fill username if password can't be set.
   if (!IsElementAutocompletable(*password_element)) {
     return false;
   }
 
   // Input matches the username, fill in required values.
   if (IsElementAutocompletable(*username_element)) {
     username_element->setValue(username, true);
-    SetElementAutofilled(username_element, true);

[Dan Beam, 2014/03/29 00:51:14]

^ this previously could've attempted to send 2 change events (but there's logic
in blink to stop this)

+    username_element->setAutofilled(true);
 
     if (set_selection) {
       username_element->setSelectionRange(current_username.length(),
                                           username.length());
     }
   } else if (current_username != username) {
     // If the username can't be filled and it doesn't match a saved password
     // as is, don't autofill a password.
     return false;
   }
 
 // TODO(vabr): The "gatekeeper" feature is currently disabled on mobile.
 // http://crbug.com/345510#c13
 #if !defined(OS_ANDROID) || !defined(OS_IOS)
   // Wait to fill in the password until a user gesture occurs. This is to make
   // sure that we do not fill in the DOM with a password until we believe the
   // user is intentionally interacting with the page.
   password_element->setSuggestedValue(password);
   gatekeeper_.RegisterElement(password_element);
 #else
   password_element->setValue(password);
 #endif
 
-  // Note: Don't call SetElementAutofilled() here, as that dispatches an
-  // onChange event in JavaScript, which is not appropriate for the password
-  // element if a user gesture has not yet occured.

[Ilya Sherman, 2014/03/29 00:07:07]

How is this case handled now?  We shouldn't trigger JS events when the user
simply previews the field.

[Dan Beam, 2014/03/29 00:51:14]

setAutofilled() doesn't dispatch a change

   password_element->setAutofilled(true);
   return true;
 }
 
 void PasswordAutofillAgent::PerformInlineAutocomplete(
     const blink::WebInputElement& username_input,
     const blink::WebInputElement& password_input,
     const PasswordFormFillData& fill_data) {
   DCHECK(!fill_data.wait_for_username);
 
@@ skipping 53 matching lines @@
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(input);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_input = input;
   *found_password = iter->second;
   return true;
 }
 
 }  // namespace autofill