Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select>

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 515 matching lines @@
 void FillFormField(const FormFieldData& data,
                    bool is_initiating_node,
                    blink::WebFormControlElement* field) {
   // Nothing to fill.
   if (data.value.empty())
     return;
 
   field->setAutofilled(true);
 
   WebInputElement* input_element = toWebInputElement(field);
+  base::string16 value = data.value;
   if (IsTextInput(input_element) || IsMonthInput(input_element)) {
     // If the maxlength attribute contains a negative value, maxLength()
     // returns the default maxlength value.
-    input_element->setValue(
-        data.value.substr(0, input_element->maxLength()), true);
-  } else if (IsTextAreaElement(*field) || IsSelectElement(*field)) {
-    if (field->value() != data.value) {
-      field->setValue(data.value);
-      field->dispatchFormControlChangeEvent();
-    }
-  } else {
-    DCHECK(IsCheckableElement(input_element));
+    value = value.substr(0, input_element->maxLength());
+  }
+
+  if (IsCheckableElement(input_element))
     input_element->setChecked(data.is_checked, true);
-  }
+  else
+    field->setValue(data.value, true);

[Ilya Sherman, 2014/03/29 00:07:07]

I noticed that you've removed the check "if (field->value() != value)".  Does
that happen automatically now?

[Dan Beam, 2014/03/29 00:51:14]

yes

 
   if (is_initiating_node &&
       ((IsTextInput(input_element) || IsMonthInput(input_element)) ||
        IsTextAreaElement(*field))) {
     int length = field->value().length();
     field->setSelectionRange(length, length);
     // Clear the current IME composition (the underline), if there is one.
     field->document().frame()->unmarkText();
   }
 }
@@ skipping 614 matching lines @@
 
 gfx::RectF GetScaledBoundingBox(float scale, WebFormControlElement* element) {
   gfx::Rect bounding_box(element->boundsInViewportSpace());
   return gfx::RectF(bounding_box.x() * scale,
                     bounding_box.y() * scale,
                     bounding_box.width() * scale,
                     bounding_box.height() * scale);
 }
 
 }  // namespace autofill