Autofill/rAc: dispatch "input"/"change" on <input>, <textarea>, and <select>

chrome/browser/autofill/autofill_interactive_uitest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 45 matching lines @@
 
 using base::ASCIIToUTF16;
 
 namespace autofill {
 
 static const char* kDataURIPrefix = "data:text/html;charset=utf-8,";
 static const char* kTestFormString =
     "<form action=\"http://www.example.com/\" method=\"POST\">"
     "<label for=\"firstname\">First name:</label>"
     " <input type=\"text\" id=\"firstname\""
-    "        onFocus=\"domAutomationController.send(true)\"><br>"
+    "        onfocus=\"domAutomationController.send(true)\"><br>"
     "<label for=\"lastname\">Last name:</label>"
     " <input type=\"text\" id=\"lastname\"><br>"
     "<label for=\"address1\">Address line 1:</label>"
     " <input type=\"text\" id=\"address1\"><br>"
     "<label for=\"address2\">Address line 2:</label>"
     " <input type=\"text\" id=\"address2\"><br>"
     "<label for=\"city\">City:</label>"
     " <input type=\"text\" id=\"city\"><br>"
     "<label for=\"state\">State:</label>"
     " <select id=\"state\">"
@@ skipping 406 matching lines @@
   SendKeyToPopupAndWait(ui::VKEY_DOWN);
 
   // Press tab to accept the autofill suggestions.
   SendKeyToPopupAndWait(ui::VKEY_TAB);
 
   // The form should be filled.
   ExpectFilledTestForm();
 }
 
 // Test that a JavaScript onchange event is fired after auto-filling a form.
-// Temporarily disabled for crbug.com/353691.
-IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
-                       DISABLED_OnChangeAfterAutofill) {
+IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, OnChangeAfterAutofill) {

[Ilya Sherman, 2014/03/29 00:07:07]

Could you also add a test for oninput?

[Dan Beam, 2014/03/29 00:51:14]

Done.

   CreateTestProfile();
 
   const char* kOnChangeScript =

[Ilya Sherman, 2014/03/29 00:07:07]

nit: While you're here... can you update this to be "const char
kOnChangeScript[]"?

[Dan Beam, 2014/03/29 00:51:14]

Done.

       "<script>"
       "focused_fired = false;"
       "unfocused_fired = false;"
       "changed_select_fired = false;"
       "unchanged_select_fired = false;"
       "document.getElementById('firstname').onchange = function() {"
       "  focused_fired = true;"
       "};"
       "document.getElementById('lastname').onchange = function() {"
       "  unfocused_fired = true;"
@@ skipping 21 matching lines @@
   // Press the down arrow to select the suggestion and preview the autofilled
   // form.
   SendKeyToPopupAndWait(ui::VKEY_DOWN);
 
   // Press Enter to accept the autofill suggestions.
   SendKeyToPopupAndWait(ui::VKEY_RETURN);
 
   // The form should be filled.
   ExpectFilledTestForm();
 
-  // The change event should have already fired for unfocused fields, both of
-  // <input> and of <select> type. However, it should not yet have fired for the
-  // focused field.
   bool focused_fired = false;
   bool unfocused_fired = false;
   bool changed_select_fired = false;
   bool unchanged_select_fired = false;
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       GetRenderViewHost(),
       "domAutomationController.send(focused_fired);",
       &focused_fired));
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       GetRenderViewHost(),
       "domAutomationController.send(unfocused_fired);",
       &unfocused_fired));
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       GetRenderViewHost(),
       "domAutomationController.send(changed_select_fired);",
       &changed_select_fired));
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       GetRenderViewHost(),
       "domAutomationController.send(unchanged_select_fired);",
       &unchanged_select_fired));
-  EXPECT_FALSE(focused_fired);
+  EXPECT_TRUE(focused_fired);
   EXPECT_TRUE(unfocused_fired);
   EXPECT_TRUE(changed_select_fired);
   EXPECT_FALSE(unchanged_select_fired);
 
   // Unfocus the first name field. Its change event should fire.
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
       GetRenderViewHost(),
       "document.getElementById('firstname').blur();"
       "domAutomationController.send(focused_fired);", &focused_fired));
   EXPECT_TRUE(focused_fired);
@@ skipping 28 matching lines @@
 // JavaScript, with only one actually visible at any given time.
 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, AutofillFormWithRepeatedField) {
   CreateTestProfile();
 
   // Load the test page.
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) +
            "<form action=\"http://www.example.com/\" method=\"POST\">"
            "<label for=\"firstname\">First name:</label>"
            " <input type=\"text\" id=\"firstname\""
-           "        onFocus=\"domAutomationController.send(true)\"><br>"
+           "        onfocus=\"domAutomationController.send(true)\"><br>"
            "<label for=\"lastname\">Last name:</label>"
            " <input type=\"text\" id=\"lastname\"><br>"
            "<label for=\"address1\">Address line 1:</label>"
            " <input type=\"text\" id=\"address1\"><br>"
            "<label for=\"address2\">Address line 2:</label>"
            " <input type=\"text\" id=\"address2\"><br>"
            "<label for=\"city\">City:</label>"
            " <input type=\"text\" id=\"city\"><br>"
            "<label for=\"state\">State:</label>"
            " <select id=\"state\">"
@@ skipping 25 matching lines @@
 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
                        AutofillFormWithNonAutofillableField) {
   CreateTestProfile();
 
   // Load the test page.
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) +
            "<form action=\"http://www.example.com/\" method=\"POST\">"
            "<label for=\"firstname\">First name:</label>"
            " <input type=\"text\" id=\"firstname\""
-           "        onFocus=\"domAutomationController.send(true)\"><br>"
+           "        onfocus=\"domAutomationController.send(true)\"><br>"
            "<label for=\"middlename\">Middle name:</label>"
            " <input type=\"text\" id=\"middlename\" autocomplete=\"off\" /><br>"
            "<label for=\"lastname\">Last name:</label>"
            " <input type=\"text\" id=\"lastname\"><br>"
            "<label for=\"address1\">Address line 1:</label>"
            " <input type=\"text\" id=\"address1\"><br>"
            "<label for=\"address2\">Address line 2:</label>"
            " <input type=\"text\" id=\"address2\"><br>"
            "<label for=\"city\">City:</label>"
            " <input type=\"text\" id=\"city\"><br>"
@@ skipping 59 matching lines @@
            "      var option2 = new Option('United States', 'US');"
            "      select_element.appendChild(option2);"
            "    }"
            ""
            "    form.appendChild(select_element);"
            "  } else {"
            "    var input_element = document.createElement('input');"
            "    input_element.setAttribute('id', name);"
            "    input_element.setAttribute('name', name);"
            ""
-           "    /* Add the onFocus listener to the 'firstname' field. */"
+           "    /* Add the onfocus listener to the 'firstname' field. */"
            "    if (name === 'firstname') {"
-           "      input_element.setAttribute("
-           "          'onFocus', 'domAutomationController.send(true)');"
+           "      input_element.onfocus = function() {"
+           "        domAutomationController.send(true);"
+           "      };"
            "    }"
            ""
            "    form.appendChild(input_element);"
            "  }"
            ""
            "  form.appendChild(document.createElement('br'));"
            "};"
            ""
            "function BuildForm() {"
            "  var elements = ["
@@ skipping 40 matching lines @@
   TryBasicFormFill();
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, AutofillAfterTranslate) {
   CreateTestProfile();
 
   GURL url(std::string(kDataURIPrefix) +
                "<form action=\"http://www.example.com/\" method=\"POST\">"
                "<label for=\"fn\">なまえ</label>"
                " <input type=\"text\" id=\"fn\""
-               "        onFocus=\"domAutomationController.send(true)\""
+               "        onfocus=\"domAutomationController.send(true)\""
                "><br>"
                "<label for=\"ln\">みょうじ</label>"
                " <input type=\"text\" id=\"ln\"><br>"
                "<label for=\"a1\">Address line 1:</label>"
                " <input type=\"text\" id=\"a1\"><br>"
                "<label for=\"a2\">Address line 2:</label>"
                " <input type=\"text\" id=\"a2\"><br>"
                "<label for=\"ci\">City:</label>"
                " <input type=\"text\" id=\"ci\"><br>"
                "<label for=\"st\">State:</label>"
@@ skipping 279 matching lines @@
   ASSERT_TRUE(content::ExecuteScript(
       GetRenderViewHost(),
       "document.querySelector('input').autocomplete = 'off';"));
 
   // Press the down arrow to select the suggestion and attempt to preview the
   // autofilled form.
   SendKeyToPopupAndWait(ui::VKEY_DOWN);
 }
 
 }  // namespace autofill