Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2061)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 214823008: Add transaction detail params to requestAutocomplete(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove newline Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/WebAutocompleteParams.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 18ed582c866f66f0acc7503116e73fa78086bde9..7be2f988be84343fd2e3849f6226031532c4adc2 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -35,6 +35,7 @@
#include "HTMLNames.h"
#include "RuntimeEnabledFeatures.h"
#include "SharedWorkerRepositoryClientImpl.h"
+#include "WebAutocompleteParams.h"
#include "WebAutofillClient.h"
#include "WebCachedURLRequest.h"
#include "WebDOMEvent.h"
@@ -53,6 +54,7 @@
#include "WebSecurityOrigin.h"
#include "WebViewClient.h"
#include "WebViewImpl.h"
+#include "bindings/v8/Dictionary.h"
#include "bindings/v8/ScriptController.h"
#include "core/dom/Document.h"
#include "core/dom/DocumentFullscreen.h"
@@ -753,10 +755,10 @@ void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(blink::W
m_webFrame->client()->willStartUsingPeerConnectionHandler(webFrame(), handler);
}
-void FrameLoaderClientImpl::didRequestAutocomplete(HTMLFormElement* form)
+void FrameLoaderClientImpl::didRequestAutocomplete(HTMLFormElement* form, const WebCore::Dictionary& details)
{
if (m_webFrame->viewImpl() && m_webFrame->viewImpl()->autofillClient())
- m_webFrame->viewImpl()->autofillClient()->didRequestAutocomplete(m_webFrame, WebFormElement(form));
+ m_webFrame->viewImpl()->autofillClient()->didRequestAutocomplete(WebFormElement(form), WebAutocompleteParams(details));
Evan Stade 2014/03/27 21:51:51 The reason I wrapped it here was to match the othe
abarth-chromium 2014/03/27 23:03:52 This seems fine to me. If you do it before callin
}
bool FrameLoaderClientImpl::allowWebGL(bool enabledPerSettings)
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/WebAutocompleteParams.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698