Add transaction detail params to requestAutocomplete().

Add transaction detail params to requestAutocomplete().

Also, remove an unnecessary param from WebAutofillClient::didRequestAutocomplete
(the frame is easy to get from the WebFormElement)

BUG=354897
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171206

[esprehn, 2014-03-27 20:05:23]

lgtm, but abarth@ should comment on the layering of the API. I'm not sure if we
can use Dictionary on the client interfaces?

[abarth-chromium, 2014-03-27 21:16:13]

On 2014/03/27 20:05:23, esprehn wrote:
> lgtm, but abarth@ should comment on the layering of the API. I'm not sure if
we
> can use Dictionary on the client interfaces?

We can.  It's probably better to extract the keys from the dictionary in core
and pass the extracted values through the client interface, but it's a matter of
style more than anything.

[Evan Stade, 2014-03-27 21:51:51]

https://codereview.chromium.org/214823008/diff/20001/Source/web/FrameLoaderCl...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/214823008/diff/20001/Source/web/FrameLoaderCl...
Source/web/FrameLoaderClientImpl.cpp:761:
m_webFrame->viewImpl()->autofillClient()->didRequestAutocomplete(WebFormElement(form),
WebAutocompleteParams(details));
The reason I wrapped it here was to match the other param. Would you like me to
wrap the dict with WebAutocompleteParams one layer up instead?

[abarth-chromium, 2014-03-27 23:03:52]

https://codereview.chromium.org/214823008/diff/20001/Source/web/FrameLoaderCl...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/214823008/diff/20001/Source/web/FrameLoaderCl...
Source/web/FrameLoaderClientImpl.cpp:761:
m_webFrame->viewImpl()->autofillClient()->didRequestAutocomplete(WebFormElement(form),
WebAutocompleteParams(details));
On 2014/03/27 21:51:51, Evan Stade wrote:
> The reason I wrapped it here was to match the other param. Would you like me
to
> wrap the dict with WebAutocompleteParams one layer up instead?

This seems fine to me.  If you do it before calling this function, you'll
probably need to introduce another struct, which doesn't seem worthwhile.

[Evan Stade, 2014-03-27 23:18:36]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2014-03-27 23:18:49]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2014-03-27 23:19:31]

OK, assuming this patch is ok to commit as is then. (Correct me if I've
misunderstood.) Still need to land the Chromium side change first though so I
don't break the build.

[Evan Stade, 2014-04-07 16:57:22]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-04-07 16:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/214823008/20001

[commit-bot: I haz the power, 2014-04-07 16:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 16:57:46]

Failed to apply patch for Source/web/WebAutocompleteParams.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/web/WebAutocompleteParams.cpp
  Copied Source/web/WebHeap.cpp -> Source/web/WebAutocompleteParams.cpp
  patching file Source/web/WebAutocompleteParams.cpp
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/WebAutocompleteParams.cpp.rej

Patch:   NR  Source/web/WebHeap.cpp->Source/web/WebAutocompleteParams.cpp
Index: Source/web/WebAutocompleteParams.cpp
diff --git a/Source/web/WebHeap.cpp b/Source/web/WebAutocompleteParams.cpp
similarity index 79%
copy from Source/web/WebHeap.cpp
copy to Source/web/WebAutocompleteParams.cpp
index
f7afef6ab2256b3feedb139abe5d62d3dac241c5..ec278dcb0f919bc66c4122b786ee5b5426da8c5e
100644
--- a/Source/web/WebHeap.cpp
+++ b/Source/web/WebAutocompleteParams.cpp
@@ -29,30 +29,22 @@
  */
 
 #include "config.h"
-#include "WebHeap.h"
+#include "WebAutocompleteParams.h"
 
-#include "heap/ThreadState.h"
+#include "bindings/v8/Dictionary.h"
+#include "public/platform/WebString.h"
+#include "wtf/text/WTFString.h"
 
 namespace blink {
 
-void WebHeap::attachThread()
+WebAutocompleteParams::WebAutocompleteParams(const WebCore::Dictionary&
details)
+    : transactionAmount(0)
 {
-    WebCore::ThreadState::attach();
-}
-
-void WebHeap::detachThread()
-{
-    WebCore::ThreadState::detach();
-}
+    details.get("transactionAmount", transactionAmount);
 
-WebHeap::SafePointScope::SafePointScope()
-{
-    WebCore::ThreadState::current()->enterSafePointWithPointers(this);
-}
-
-WebHeap::SafePointScope::~SafePointScope()
-{
-    WebCore::ThreadState::current()->leaveSafePoint();
+    String currency;
+    if (details.get("transactionCurrency", currency))
+        transactionCurrency = WebString(currency);
 }
 
 } // namespace blink

[Evan Stade, 2014-04-07 22:06:02]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-04-07 22:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/214823008/40001

[commit-bot: I haz the power, 2014-04-07 22:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 22:20:24]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[Evan Stade, 2014-04-08 21:34:47]

Adam can you give an OWNERS review for

    Source/web/FrameLoaderClientImpl.cpp
    Source/web/FrameLoaderClientImpl.h
    Source/web/WebAutocompleteParams.cpp
    Source/web/web.gypi
    public/web/WebAutocompleteParams.h
    public/web/WebAutofillClient.h

[abarth-chromium, 2014-04-08 23:40:12]

public/web, Source/web LGTM

[Evan Stade, 2014-04-10 00:36:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-04-10 00:36:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/214823008/40001

[commit-bot: I haz the power, 2014-04-10 00:46:57]

Change committed as 171206