Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214823006: Move ContentBrowserTest class to content/public, since it's used by components_browsertests for bro… (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, alecflett, nasko+codewatch_chromium.org, yoshiki+watch_chromium.org, ericu+idb_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, dgrogan, dmazzoni+watch_chromium.org, kinuko+watch, aandrey+blink_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, vsevik, aboxhall+watch_chromium.org, tzik, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, creis+watch_chromium.org, dtseng+watch_chromium.org, benjhayden+dwatch_chromium.org, penghuang+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, timvolodine, Michael van Ouwerkerk, piman+watch_chromium.org, dcheng, jsbell+idb_chromium.org, darin (slow to review), alecflett+watch_chromium.org, michaeln, plundblad+watch_chromium.org, serviceworker-reviews, yurys, Aaron Boodman, yuzo+watch_chromium.org, dsinclair+watch_chromium.org, cmumford, horo+watch_chromium.org, danakj+watch_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Move ContentBrowserTest class to content/public, since it's used by components_browsertests for browser tests which use Content Shell. R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259967

Patch Set 1 #

Patch Set 2 : fix mac #

Total comments: 2

Patch Set 3 : remove other files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -556 lines) Patch
M components/dom_distiller/content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/standalone/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/mojo/mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/bookmarklet_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/image_transport_factory_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/database_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/device_orientation/device_inertial_sensor_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/media_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_aecdump_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/input_tag_speech_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/site_isolation_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +7 lines, -8 lines 0 comments Download
A + content/public/test/content_browser_test.h View 2 chunks +4 lines, -6 lines 0 comments Download
A + content/public/test/content_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/content_browser_test_utils.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + content/public/test/content_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/content_browser_test_utils_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_render_view_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/savable_resources_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/test/content_browser_test.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/test/content_browser_test.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/test/content_browser_test_utils.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/test/content_browser_test_utils.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D content/test/content_browser_test_utils_mac.mm View 1 chunk +0 lines, -25 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webui_resource_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 9 months ago (2014-03-27 18:28:24 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/214823006/diff/20001/chrome/test/mini_installer/variable_expander.py File chrome/test/mini_installer/variable_expander.py (right): https://codereview.chromium.org/214823006/diff/20001/chrome/test/mini_installer/variable_expander.py#newcode112 chrome/test/mini_installer/variable_expander.py:112: (mini_installer_product_name, mini_installer_abspath)) What's this doing in this CL? https://codereview.chromium.org/214823006/diff/20001/content/child/child_thread.cc ...
6 years, 9 months ago (2014-03-27 18:36:49 UTC) #2
jam
thanks, removed extraneous files
6 years, 9 months ago (2014-03-27 19:34:22 UTC) #3
Avi (use Gerrit)
6 years, 9 months ago (2014-03-27 19:37:32 UTC) #4 
LGTM then.

Powered by Google App Engine
This is Rietveld 408576698