Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: content/renderer/media/video_frame_compositor.h

Issue 214823005: Remove requirement of compositing a video frame for dropped frame count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/video_frame_compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_frame_compositor.h
diff --git a/content/renderer/media/video_frame_compositor.h b/content/renderer/media/video_frame_compositor.h
index 47e6ad19fe69ef1e5c349219f7b811fb1943ed6e..7a8b0a8a20b6a9b08a006d567134619843f51940 100644
--- a/content/renderer/media/video_frame_compositor.h
+++ b/content/renderer/media/video_frame_compositor.h
@@ -52,18 +52,18 @@ class CONTENT_EXPORT VideoFrameCompositor {
void UpdateCurrentFrame(const scoped_refptr<media::VideoFrame>& frame);
// Retrieves the last frame set via UpdateCurrentFrame() for non-compositing
- // purposes (e.g., painting to a canvas). Frames retrieved in this manner will
- // not be counted as being composited for frame drop counting.
+ // purposes (e.g., painting to a canvas).
//
// Note that the compositor retrieves frames via the cc::VideoFrameProvider
// interface instead of using this method.
scoped_refptr<media::VideoFrame> GetCurrentFrame();
- // Returns the number of frames dropped before the compositor was notified as
- // well as being able to composite the previous frame.
- uint32 GetFramesDroppedBeforeComposite();
+ // Returns the number of frames dropped before the compositor was notified
+ // of a new frame.
+ uint32 GetFramesDroppedBeforeCompositorWasNotified();
- void SetFramesDroppedBeforeCompositeForTesting(uint32 dropped_frames);
+ void SetFramesDroppedBeforeCompositorWasNotifiedForTesting(
+ uint32 dropped_frames);
private:
class Internal;
« no previous file with comments | « no previous file | content/renderer/media/video_frame_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698