Recommend base::test::ScopedCommandLine usage.

Recommend base::test::ScopedCommandLine usage.

For those tempted to call base::CommandLine::Reset().

Clean up some nits while we are here.

Committed: https://crrev.com/fd08568865e3c132778e4468abfe71e0528ec98c
Cr-Commit-Position: refs/heads/master@{#405684}

[Lei Zhang, 2016-07-14 10:24:22]

thestig@chromium.org changed reviewers:
+ mark@chromium.org

[Lei Zhang, 2016-07-14 10:24:22]

See my comments on https://codereview.chromium.org/2047253002 for why I'm adding
this.

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h
File base/command_line.h (right):

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h#newcode163
base/command_line.h:163: bool HasSwitch(const StringPiece& switch_string) const;
Shall we pass these by value while we are here?

[Mark Mentovai, 2016-07-14 14:24:02]

LGTM

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h
File base/command_line.h (right):

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h#newcode163
base/command_line.h:163: bool HasSwitch(const StringPiece& switch_string) const;
Lei Zhang (Slow Thursday) wrote:
> Shall we pass these by value while we are here?

How would that help?

[Lei Zhang, 2016-07-15 00:44:39]

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h
File base/command_line.h (right):

https://codereview.chromium.org/2148213002/diff/1/base/command_line.h#newcode163
base/command_line.h:163: bool HasSwitch(const StringPiece& switch_string) const;
On 2016/07/14 14:24:02, Mark Mentovai wrote:
> Lei Zhang (Slow Thursday) wrote:
> > Shall we pass these by value while we are here?
> 
> How would that help?

base::StringPiece (and base::Time) says to prefer passing by value, but others
pass by ref for consistency. Not sure if you had a strong opinion on this.

[Lei Zhang, 2016-07-15 00:44:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 02:50:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 02:50:36]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 02:52:50]

Description was changed from

==========
Recommend base::test::ScopedCommandLine usage.

For those tempted to call base::CommandLine::Reset().

Clean up some nits while we are here.
==========

to

==========
Recommend base::test::ScopedCommandLine usage.

For those tempted to call base::CommandLine::Reset().

Clean up some nits while we are here.

Committed: https://crrev.com/fd08568865e3c132778e4468abfe71e0528ec98c
Cr-Commit-Position: refs/heads/master@{#405684}
==========

[commit-bot: I haz the power, 2016-07-15 02:52:51]

Patchset 1 (id:??) landed as
https://crrev.com/fd08568865e3c132778e4468abfe71e0528ec98c
Cr-Commit-Position: refs/heads/master@{#405684}