Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: chrome/browser/download/save_package.cc

Issue 21482: Fix save complete .html page. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_package.cc
===================================================================
--- chrome/browser/download/save_package.cc (revision 9983)
+++ chrome/browser/download/save_package.cc (working copy)
@@ -961,19 +961,12 @@
// Since we take the suggested name from the web page's title, we want to
// ignore the file extension generated by SaveFileAsWithFilter, since it
// will always be ".htm".
- // TODO(estade): is this saved_main_file_path assignment behavior desired?
- // It was copied from previous code but seems strange.
std::wstring main_file_path;
- if (!win_util::SaveFileAsWithFilter(container_hwnd,
- suggest_name.value(),
- filter,
- L"htm",
- true,
- &index,
- &main_file_path)) {
- param->saved_main_file_path = FilePath(main_file_path);
+ bool success = win_util::SaveFileAsWithFilter(container_hwnd,
+ suggest_name.value(), filter, L"htm", true, &index, &main_file_path);
+ param->saved_main_file_path = FilePath(main_file_path);
+ if (!success)
return false;
- }
} else {
param->saved_main_file_path = suggest_name;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698