Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2148163003: Fix asserts in gcm_client_impl_unittest (Closed)

Created:
4 years, 5 months ago by johnme
Modified:
4 years, 5 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix asserts in gcm_client_impl_unittest Many of the tests were calling helper methods that ASSERT, without wrapping those calls with ASSERT_NO_FATAL_FAILURE to propagate any assertion failures to the test. This patch wraps the calls. BUG=none Committed: https://crrev.com/0fb2fc0f442e3f9390d0521b19603b8095fecb23 Cr-Commit-Position: refs/heads/master@{#405494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -82 lines) Patch
M components/gcm_driver/gcm_client_impl_unittest.cc View 32 chunks +67 lines, -82 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
johnme
4 years, 5 months ago (2016-07-14 11:47:19 UTC) #2
Peter Beverloo
lgtm
4 years, 5 months ago (2016-07-14 13:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148163003/1
4 years, 5 months ago (2016-07-14 14:13:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 14:47:58 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 14:48:04 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 14:49:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fb2fc0f442e3f9390d0521b19603b8095fecb23
Cr-Commit-Position: refs/heads/master@{#405494}

Powered by Google App Engine
This is Rietveld 408576698