Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2148163002: Revert of Don't compile functions in a context the caller doesn't have access to (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Don't compile functions in a context the caller doesn't have access to (patchset #9 id:160001 of https://codereview.chromium.org/2034083002/ ) Reason for revert: Causes crashes on Canary Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead just return undefined > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > BUG=chromium:541703 > R=verwaest@chromium.org,bmeurer@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng > > Committed: https://crrev.com/992e34c21635b179a993b82ac1d81753e7a6a57a > Cr-Commit-Position: refs/heads/master@{#37657} TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:541703, chromium:628053 Committed: https://crrev.com/68f205b2a7a0e3a344294d7d707fcebaa4cc8b87 Cr-Commit-Position: refs/heads/master@{#37736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -185 lines) Patch
M include/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 6 chunks +15 lines, -26 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 2 chunks +0 lines, -76 lines 0 comments Download
M test/mjsunit/es6/reflect-construct.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
adamk
Created Revert of Don't compile functions in a context the caller doesn't have access to
4 years, 5 months ago (2016-07-14 01:34:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148163002/1
4 years, 5 months ago (2016-07-14 01:34:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 01:59:34 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:02:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68f205b2a7a0e3a344294d7d707fcebaa4cc8b87
Cr-Commit-Position: refs/heads/master@{#37736}

Powered by Google App Engine
This is Rietveld 408576698