Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: git_cl.py

Issue 2148153002: Fix per-file owners check for deleted files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Rebase! Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | owners.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 70d7e18c9a58f658c0c21462a92c76049e3a3830..6a59cda52b9aa21facb9041e22bd9b86135569a7 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -13,7 +13,6 @@ from distutils.version import LooseVersion
from multiprocessing.pool import ThreadPool
import base64
import collections
-import glob
import httplib
import json
import logging
@@ -2721,7 +2720,7 @@ class ChangeDescription(object):
reviewers.append(name)
if add_owners_tbr:
owners_db = owners.Database(change.RepositoryRoot(),
- fopen=file, os_path=os.path, glob=glob.glob)
+ fopen=file, os_path=os.path)
all_reviewers = set(tbr_names + reviewers)
missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
all_reviewers)
@@ -4841,7 +4840,7 @@ def CMDowners(parser, args):
[f.LocalPath() for f in
cl.GetChange(base_branch, None).AffectedFiles()],
change.RepositoryRoot(), author,
- fopen=file, os_path=os.path, glob=glob.glob,
+ fopen=file, os_path=os.path,
disable_color=options.no_color).run()
« no previous file with comments | « no previous file | owners.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698