Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 214813002: Ignore anything after '@' in SCMWrapper.DoesRemoteURLMatch (Closed)

Created:
6 years, 9 months ago by borenet
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Ignore anything after '@' in SCMWrapper.DoesRemoteURLMatch BUG=356881 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260887

Patch Set 1 #

Patch Set 2 : Use gclient_urils.SplitUrlRevision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gclient_scm.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
borenet
This seems like a reasonable fix to me. Thoughts?
6 years, 9 months ago (2014-03-27 15:01:40 UTC) #1
iannucci
lgtm
6 years, 9 months ago (2014-03-28 18:46:59 UTC) #2
iannucci
Actually, is there anything we can do to ensure that this isn't splitting a username? ...
6 years, 9 months ago (2014-03-28 18:47:49 UTC) #3
borenet
On 2014/03/28 18:47:49, iannucci wrote: > Actually, is there anything we can do to ensure ...
6 years, 9 months ago (2014-03-28 20:39:19 UTC) #4
borenet
On 2014/03/28 20:39:19, borenet wrote: > On 2014/03/28 18:47:49, iannucci wrote: > > Actually, is ...
6 years, 8 months ago (2014-03-31 17:00:35 UTC) #5
iannucci
lgtm
6 years, 8 months ago (2014-03-31 21:11:07 UTC) #6
borenet
The CQ bit was checked by borenet@google.com
6 years, 8 months ago (2014-04-01 16:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/214813002/20001
6 years, 8 months ago (2014-04-01 16:39:44 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 16:41:37 UTC) #9
Message was sent while issue was closed.
Change committed as 260887

Powered by Google App Engine
This is Rietveld 408576698