GN: Use the correct defaults for templates invoked via target().

GN: Use the correct defaults for templates invoked via target().

Previously calling
  target("foo", "bar")
where "foo" is a template applied the defaults for the function named "target"
(since this is the function call) rather than "foo".

This change properly applies the defaults for "foo" in this case.

BUG=624564
Committed: https://crrev.com/af92718f5526ce94ea8fcb4118f850fb9a7517b3
Cr-Commit-Position: refs/heads/master@{#405547}

[brettw, 2016-07-13 22:14:45]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-07-13 22:14:50]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:16:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:19:05]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-07-14 17:25:44]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org
- dpranke@chromium.org

[brettw, 2016-07-14 17:25:45]

-> Bruce, I think Dirk is busy.

[brucedawson, 2016-07-14 17:39:26]

lgtm with one nit.

https://codereview.chromium.org/2148093002/diff/1/tools/gn/functions.cc
File tools/gn/functions.cc (right):

https://codereview.chromium.org/2148093002/diff/1/tools/gn/functions.cc#newco...
tools/gn/functions.cc:1039: std::string template_name =
function->function().value().as_string();
Should be const std::string - or maybe const auto?

[Dirk Pranke, 2016-07-14 19:14:24]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-07-14 19:14:25]

lgtm

[brettw, 2016-07-14 19:26:38]

https://codereview.chromium.org/2148093002/diff/1/tools/gn/functions.cc
File tools/gn/functions.cc (right):

https://codereview.chromium.org/2148093002/diff/1/tools/gn/functions.cc#newco...
tools/gn/functions.cc:1039: std::string template_name =
function->function().value().as_string();
I don't actually like "const" for local variables unless they're pointers or
references to something. I feel like this adds noise without much benefit. I'm
aware that other people like this, but I don't think it's a requirement and I've
been pretty consistent not doing this in the GN code.

[brucedawson, 2016-07-14 19:36:53]

I *love* const for local variables, but we'll have to agree to disagree, or
debate it in person sometime.

lgtm

[brettw, 2016-07-14 19:37:50]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-07-14 19:39:06]

On 2016/07/14 19:36:53, brucedawson wrote:
> I *love* const for local variables, but we'll have to agree to disagree, or
> debate it in person sometime.

Are you also one of those crazy "const Foo const * const * const" people? :P

[commit-bot: I haz the power, 2016-07-14 19:44:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 19:44:28]

CQ bit was unchecked.

[brucedawson, 2016-07-14 19:45:12]

On 2016/07/14 19:39:06, brettw (ping after 24h) wrote:
> On 2016/07/14 19:36:53, brucedawson wrote:
> > I *love* const for local variables, but we'll have to agree to disagree, or
> > debate it in person sometime.
> 
> Are you also one of those crazy "const Foo const * const * const" people? :P

I don't approve of redundant const redundant const qualifiers, but otherwise,
maybe?

I just like that a const local (or parameter) tells the reader some additional
information, and sometimes I've found that helpful.

[commit-bot: I haz the power, 2016-07-14 19:46:34]

Description was changed from

==========
GN: Use the correct defaults for templates invoked via target().

Previously calling
  target("foo", "bar")
where "foo" is a template applied the defaults for the function named "target"
(since this is the function call) rather than "foo".

This change properly applies the defaults for "foo" in this case.

BUG=624564
==========

to

==========
GN: Use the correct defaults for templates invoked via target().

Previously calling
  target("foo", "bar")
where "foo" is a template applied the defaults for the function named "target"
(since this is the function call) rather than "foo".

This change properly applies the defaults for "foo" in this case.

BUG=624564

Committed: https://crrev.com/af92718f5526ce94ea8fcb4118f850fb9a7517b3
Cr-Commit-Position: refs/heads/master@{#405547}
==========

[commit-bot: I haz the power, 2016-07-14 19:46:35]

Patchset 1 (id:??) landed as
https://crrev.com/af92718f5526ce94ea8fcb4118f850fb9a7517b3
Cr-Commit-Position: refs/heads/master@{#405547}