V8. ASM-2-WASM. Fixes technical debt in asm-types.

V8. ASM-2-WASM. Fixes technical debt in asm-types.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST= cctest/asmjs/test-asm-typer
LOG=N

Committed: https://crrev.com/08fed37ef1b6428e963afa060ce6d356cdf9649f
Cr-Commit-Position: refs/heads/master@{#37731}

[John, 2016-07-13 21:27:53]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 21:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-07-13 21:28:04]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:50:42]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-07-13 22:06:39]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-07-13 22:06:40]

lgtm

[commit-bot: I haz the power, 2016-07-13 22:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:09:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 22:11:31]

Description was changed from

==========
V8. ASM-2-WASM. Fixes technical debt in asm-types.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST= cctest/asmjs/test-asm-typer
LOG=N
==========

to

==========
V8. ASM-2-WASM. Fixes technical debt in asm-types.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST= cctest/asmjs/test-asm-typer
LOG=N

Committed: https://crrev.com/08fed37ef1b6428e963afa060ce6d356cdf9649f
Cr-Commit-Position: refs/heads/master@{#37731}
==========

[commit-bot: I haz the power, 2016-07-13 22:11:32]

Patchset 1 (id:??) landed as
https://crrev.com/08fed37ef1b6428e963afa060ce6d356cdf9649f
Cr-Commit-Position: refs/heads/master@{#37731}

[John, 2016-07-13 22:54:37]

Pretty please!!!

https://codereview.chromium.org/2148073002/diff/1/test/unittests/wasm/asm-typ...
File test/unittests/wasm/asm-types-unittest.cc (right):

https://codereview.chromium.org/2148073002/diff/1/test/unittests/wasm/asm-typ...
test/unittests/wasm/asm-types-unittest.cc:269: if (auto* func_a =
a->AsFunctionType()) {
Brad, I'm OOO right now, so can you please send a cl out removing func_a and
func_b:

if (a->AsFunctionType() != nullptr)
  if (b->AsFunctionType() != nullptr)
    return a->IsA(b);

[bradn, 2016-07-13 23:18:46]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-07-13 23:18:47]

Will do