Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4068)

Unified Diff: components/pdf/renderer/pepper_pdf_host.cc

Issue 2148063002: Add some CHECKs to PepperPDFHost to figure out a crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pdf/renderer/pepper_pdf_host.cc
diff --git a/components/pdf/renderer/pepper_pdf_host.cc b/components/pdf/renderer/pepper_pdf_host.cc
index ab9418b33db14ef60cd5f21fd768156e506731a6..638c2089fdf8765f380a231502b27a975a60c2f1 100644
--- a/components/pdf/renderer/pepper_pdf_host.cc
+++ b/components/pdf/renderer/pepper_pdf_host.cc
@@ -142,6 +142,11 @@ int32_t PepperPDFHost::OnHostMsgHasUnsupportedFeature(
if (!instance)
return PP_ERROR_FAILED;
+ // TODO(thestig): Turn CHECKs into the proper if statement after figuring ut
tommycli 2016/07/13 21:51:02 nit: "figuring ut" typo
Lei Zhang 2016/07/13 21:52:45 Clearly a case of packet loss between chair and ke
+ // what's wrong for https://crbug.com/627814
+ CHECK(instance->GetContainer());
+ CHECK(instance->GetContainer()->document().frame());
+ CHECK(instance->GetContainer()->document().frame()->view());
blink::WebView* view =
instance->GetContainer()->document().frame()->view();
content::RenderView* render_view = content::RenderView::FromWebView(view);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698