Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2148063002: Add some CHECKs to PepperPDFHost to figure out a crash. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some CHECKs to PepperPDFHost to figure out a crash. BUG=627814 Committed: https://crrev.com/a0cec3faf14da6bd8f78b8bfaa6147af8926a3e8 Cr-Commit-Position: refs/heads/master@{#405338}

Patch Set 1 #

Patch Set 2 : TODO #

Total comments: 2

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/pdf/renderer/pepper_pdf_host.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
4 years, 5 months ago (2016-07-13 21:10:07 UTC) #2
tommycli
LGTM sans: https://codereview.chromium.org/2148063002/diff/20001/components/pdf/renderer/pepper_pdf_host.cc File components/pdf/renderer/pepper_pdf_host.cc (right): https://codereview.chromium.org/2148063002/diff/20001/components/pdf/renderer/pepper_pdf_host.cc#newcode145 components/pdf/renderer/pepper_pdf_host.cc:145: // TODO(thestig): Turn CHECKs into the proper ...
4 years, 5 months ago (2016-07-13 21:51:02 UTC) #5
Lei Zhang
https://codereview.chromium.org/2148063002/diff/20001/components/pdf/renderer/pepper_pdf_host.cc File components/pdf/renderer/pepper_pdf_host.cc (right): https://codereview.chromium.org/2148063002/diff/20001/components/pdf/renderer/pepper_pdf_host.cc#newcode145 components/pdf/renderer/pepper_pdf_host.cc:145: // TODO(thestig): Turn CHECKs into the proper if statement ...
4 years, 5 months ago (2016-07-13 21:52:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148063002/40001
4 years, 5 months ago (2016-07-13 21:53:51 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 23:06:43 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:10:01 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0cec3faf14da6bd8f78b8bfaa6147af8926a3e8
Cr-Commit-Position: refs/heads/master@{#405338}

Powered by Google App Engine
This is Rietveld 408576698