Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2148053002: PRESUBMIT: use "master." prefix in CQ_INCLUDE_TRYBOTS. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
jam, Will Harris
CC:
chromium-reviews, creis+watch_chromium.org, binji+watch_chromium.org, wfh+watch_chromium.org, nasko+codewatch_chromium.org, jam, rickyz+watch_chromium.org, haraken, darin-cc_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, blink-reviews, piman+watch_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, Sam Clegg, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PRESUBMIT: use "master." prefix in CQ_INCLUDE_TRYBOTS. R=jam@chromium.org,danakj@chromium.org,kbr@chromium.org BUG=617627 Committed: https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56 Cr-Commit-Position: refs/heads/master@{#405365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M PRESUBMIT.py View 1 chunk +6 lines, -6 lines 0 comments Download
M PRESUBMIT_test.py View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/win/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/drmemory/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
tandrii(chromium)
PTAL
4 years, 5 months ago (2016-07-13 20:52:25 UTC) #8
Will Harris
sandbox/win/PRESUBMIT.py lgtm. thanks for fixing this up. might it have been worth doing this before ...
4 years, 5 months ago (2016-07-13 21:18:48 UTC) #11
tandrii(chromium)
On 2016/07/13 21:18:48, Will Harris wrote: > sandbox/win/PRESUBMIT.py lgtm. thanks for fixing this up. might ...
4 years, 5 months ago (2016-07-13 21:23:58 UTC) #12
jam
rubberstamp lgtm
4 years, 5 months ago (2016-07-13 22:15:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148053002/1
4 years, 5 months ago (2016-07-14 00:26:14 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 00:35:03 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:38:02 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5587794fa922c30fe4ef22857f20721f75c5e56
Cr-Commit-Position: refs/heads/master@{#405365}

Powered by Google App Engine
This is Rietveld 408576698