Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2148043002: Whitelist extension APIs from md-settings in settings (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Devlin, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist extension APIs from md-settings in settings If the MaterialDesignSettings feature is enabled, chrome://settings loads MD settings, so whitelist extension APIs there too. The test will involve adding the MaterialDesignSettings feature and checking for console errors. Looking into the best way to do that. BUG=627932 R=dbeam@chromium.org Committed: https://crrev.com/e88ced52cb6cfc584882b726f142b13db97d2f1c Cr-Commit-Position: refs/heads/master@{#405332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/common/extensions/api/_api_features.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michaelpg
this whitelists new APIs in old Settings if MaterialDesignSettings is not enabled... is that OK?
4 years, 5 months ago (2016-07-13 20:18:36 UTC) #1
Dan Beam
yeah, probably fine lgtm /cc rdevlin.cronin@ as fyi (we're opening up some private extension APIs ...
4 years, 5 months ago (2016-07-13 21:24:58 UTC) #2
Devlin
On 2016/07/13 21:24:58, Dan Beam wrote: > yeah, probably fine > > lgtm > > ...
4 years, 5 months ago (2016-07-13 21:27:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148043002/1
4 years, 5 months ago (2016-07-13 21:30:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 22:56:26 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:59:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e88ced52cb6cfc584882b726f142b13db97d2f1c
Cr-Commit-Position: refs/heads/master@{#405332}

Powered by Google App Engine
This is Rietveld 408576698