Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 2148013002: Revert of Color: Don't duplicate ICC profile data (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
hubbe, ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Color: Don't duplicate ICC profile data (patchset #3 id:40001 of https://codereview.chromium.org/2140803002/ ) Reason for revert: Broke static initializers step of sizes on Linux: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/22278 Maybe making map_ a base::LazyInstance would solve your problem? Original issue's description: > Color: Don't duplicate ICC profile data > > Make gfx::ColorSpace have an internal pointer to a globally-unique > structure for the color space, where its ICC profile can be stored. > > BUG=622133 > > Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320 > Cr-Commit-Position: refs/heads/master@{#405211} TBR=hubbe@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622133 Committed: https://crrev.com/075682d2247db4715899446dfcebd22ba952882a Cr-Commit-Position: refs/heads/master@{#405221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -123 lines) Patch
M ui/gfx/color_space.h View 4 chunks +2 lines, -17 lines 0 comments Download
M ui/gfx/color_space.cc View 3 chunks +5 lines, -100 lines 0 comments Download
M ui/gfx/color_space_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/color_space_x11.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dan Beam
Created Revert of Color: Don't duplicate ICC profile data
4 years, 5 months ago (2016-07-13 19:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148013002/1
4 years, 5 months ago (2016-07-13 19:20:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:22:48 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:23:44 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:25:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/075682d2247db4715899446dfcebd22ba952882a
Cr-Commit-Position: refs/heads/master@{#405221}

Powered by Google App Engine
This is Rietveld 408576698