AX: Don't use listIndex in AXListBoxOption class.

AX: Don't use listIndex in AXListBoxOption class.

* AXListBoxOption::isSelectedOptionActive()
  We don't need to compare indices. We can compare node pointers.

* AXListBoxOption::setSelected()
  We don't need to compute an optionIndex.  We can pass an HTMLOptionElement
  pointer directly by changing the argument type of accessKeySetSelectedIndex().
  This CL renames accessKeySetSelectedIndex() to selectOptionByAccessKey().

Now, we can remove AXListBoxOption::listBoxOptionIndex() and
HTMLSelectElement::listToOptionIndex().

Committed: https://crrev.com/27b62f450269f5a49376ca2f44423340a8a53903
Cr-Commit-Position: refs/heads/master@{#405500}

[tkent, 2016-07-14 06:42:50]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 06:43:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-14 08:22:41]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-07-14 08:22:41]

Keishi, would you review this please?

[commit-bot: I haz the power, 2016-07-14 09:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:05:15]

Dry run: This issue passed the CQ dry run.

[keishi, 2016-07-14 12:20:39]

LGTM

[tkent, 2016-07-14 15:46:57]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-14 15:47:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 15:51:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 15:52:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 15:53:11]

Description was changed from

==========
AX: Don't use listIndex in AXListBoxOption class.

* AXListBoxOption::isSelectedOptionActive()
  We don't need to compare indices. We can compare node pointers.

* AXListBoxOption::setSelected()
  We don't need to compute an optionIndex.  We can pass an HTMLOptionElement
  pointer directly by changing the argument type of accessKeySetSelectedIndex().
  This CL renames accessKeySetSelectedIndex() to selectOptionByAccessKey().

Now, we can remove AXListBoxOption::listBoxOptionIndex() and
HTMLSelectElement::listToOptionIndex().
==========

to

==========
AX: Don't use listIndex in AXListBoxOption class.

* AXListBoxOption::isSelectedOptionActive()
  We don't need to compare indices. We can compare node pointers.

* AXListBoxOption::setSelected()
  We don't need to compute an optionIndex.  We can pass an HTMLOptionElement
  pointer directly by changing the argument type of accessKeySetSelectedIndex().
  This CL renames accessKeySetSelectedIndex() to selectOptionByAccessKey().

Now, we can remove AXListBoxOption::listBoxOptionIndex() and
HTMLSelectElement::listToOptionIndex().

Committed: https://crrev.com/27b62f450269f5a49376ca2f44423340a8a53903
Cr-Commit-Position: refs/heads/master@{#405500}
==========

[commit-bot: I haz the power, 2016-07-14 15:53:13]

Patchset 1 (id:??) landed as
https://crrev.com/27b62f450269f5a49376ca2f44423340a8a53903
Cr-Commit-Position: refs/heads/master@{#405500}