Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2147943002: Revert of [turbofan] Do not use the self reference for turbofan functions. (Closed)

Created:
4 years, 5 months ago by Michael Hablich
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Do not use the self reference for turbofan functions. (patchset #2 id:20001 of https://codereview.chromium.org/2150523002/ ) Reason for revert: Dependency of the roll unblocking revert https://codereview.chromium.org/2147883003/ Original issue's description: > [turbofan] Do not use the self reference for turbofan functions. > > The self reference requires the allocation of a handle in the macro > assembler, which is not possible if we instantiate the macro assembler > in a worker thread. > > R=mstarzinger@chromium.org, bmeurer@chromium.org > > Committed: https://crrev.com/49ef529b3af50f5daadacdcdcd6be3a307c10af5 > Cr-Commit-Position: refs/heads/master@{#37713} TBR=bmeurer@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1b42dae4bbecb3fae292ec5d108911339992b34b Cr-Commit-Position: refs/heads/master@{#37716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/codegen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/codegen.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [turbofan] Do not use the self reference for turbofan functions.
4 years, 5 months ago (2016-07-13 14:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147943002/1
4 years, 5 months ago (2016-07-13 14:19:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 14:19:19 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:20:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b42dae4bbecb3fae292ec5d108911339992b34b
Cr-Commit-Position: refs/heads/master@{#37716}

Powered by Google App Engine
This is Rietveld 408576698